[jira] [Commented] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220672#comment-17220672
 ] 

Hudson commented on HBASE-25195:


Results for branch branch-1
[build #47 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/47/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/47//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/47//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/47//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> [branch-1] getNumOpenConnections is not effective
> -
>
> Key: HBASE-25195
> URL: https://issues.apache.org/jira/browse/HBASE-25195
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>
> In MetricsHBaseServerWrapperImpl
> {code}
>   @Override
>   public int getNumOpenConnections() {
> if (!isServerStarted() || this.server.connectionList == null) {
>   return 0;
> }
> return server.connectionList.size();
>   }
> {code}
> But connectionList is created by Collections.synchronizedList(new 
> LinkedList());
> So each connectionList.size() will compete for the mutex, we can easily 
> replace it with another parameter *numConnections*, as for metrics, it is 
> enough.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

[Reid Chan (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216113#comment-17216113
 ] 

Reid Chan commented on HBASE-25195:
---

branch-2+ don't have this issue. 

> [branch-1] getNumOpenConnections is not effective
> -
>
> Key: HBASE-25195
> URL: https://issues.apache.org/jira/browse/HBASE-25195
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics
> Environment: In MetricsHBaseServerWrapperImpl
> {code}
>   @Override
>   public int getNumOpenConnections() {
> if (!isServerStarted() || this.server.connectionList == null) {
>   return 0;
> }
> return server.connectionList.size();
>   }
> {code}
> But connectionList is created by Collections.synchronizedList(new 
> LinkedList());
> So each connectionList.size() will compete for the mutex, we can easily 
> replace it with another parameter *numConnections*, as for metrics, it is 
> enough.
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)