[jira] [Commented] (HBASE-25285) [branch-1] Fix two methods removed problems reported by compat-check

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238777#comment-17238777
 ] 

Hudson commented on HBASE-25285:


Results for branch branch-1
[build #58 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/58/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/58//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/58//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/58//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> [branch-1] Fix two methods removed problems reported by compat-check
> 
>
> Key: HBASE-25285
> URL: https://issues.apache.org/jira/browse/HBASE-25285
> Project: HBase
>  Issue Type: Bug
>  Components: API
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 1.7.0
>
>
> {code}
> hbase-server-1.6.0.jar, RpcServerInterface.class
> package org.apache.hadoop.hbase.ipc
> RpcServerInterface.refreshAuthManager ( PolicyProvider p1 ) [abstract]  :  
> void
> hbase-server-1.6.0.jar, Store.class
> package org.apache.hadoop.hbase.regionserver
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6 ) [abstract]  :  StoreFile.Writer
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6, TimeRangeTracker p7 ) [abstract]  :  
> StoreFile.Writer
> {code}
> These two removed methods may be problematic, let's review them again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25285) [branch-1] Fix two methods removed problems reported by compat-check

[Reid Chan (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232572#comment-17232572
 ] 

Reid Chan commented on HBASE-25285:
---

Because they are HBaseInterfaceAudience.COPROC.
Let's keep them, just in case any coprocessor uses.

> [branch-1] Fix two methods removed problems reported by compat-check
> 
>
> Key: HBASE-25285
> URL: https://issues.apache.org/jira/browse/HBASE-25285
> Project: HBase
>  Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
>
> {code}
> hbase-server-1.6.0.jar, RpcServerInterface.class
> package org.apache.hadoop.hbase.ipc
> RpcServerInterface.refreshAuthManager ( PolicyProvider p1 ) [abstract]  :  
> void
> hbase-server-1.6.0.jar, Store.class
> package org.apache.hadoop.hbase.regionserver
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6 ) [abstract]  :  StoreFile.Writer
> Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, 
> boolean p4, boolean p5, boolean p6, TimeRangeTracker p7 ) [abstract]  :  
> StoreFile.Writer
> {code}
> These two removed methods may be problematic, let's review them again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)