[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242866#comment-17242866 ] Reid Chan commented on HBASE-25308: --- Got it, thanks for clarification. > [branch-1] Consume Guava

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-02 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242570#comment-17242570 ] Andrew Kyle Purtell commented on HBASE-25308: - Oh, this patch cannot work until there is an

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-01 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242019#comment-17242019 ] Reid Chan commented on HBASE-25308: --- Leave alone checkstyle, there's *COMPILATION ERROR* > [branch-1]

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-01 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242018#comment-17242018 ] Reid Chan commented on HBASE-25308: --- do we need to take care those (x)? Or we can just directly merge

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-01 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242015#comment-17242015 ] Andrew Kyle Purtell commented on HBASE-25308: - All the patch does is change imports to use

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-01 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242012#comment-17242012 ] Andrew Kyle Purtell commented on HBASE-25308: - Can you clarify? What needs to be polished?

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-12-01 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242010#comment-17242010 ] Reid Chan commented on HBASE-25308: --- Looked at the PR, many codes need to be polished > [branch-1]

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-23 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237674#comment-17237674 ] Andrew Kyle Purtell commented on HBASE-25308: - HBASE-24640 proposes to remove

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-20 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236562#comment-17236562 ] Andrew Kyle Purtell commented on HBASE-25308: - I filed HBASE-25316 for a hbase-thirdparty

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235854#comment-17235854 ] Andrew Kyle Purtell commented on HBASE-25308: - This project produced a massive PR here

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-19 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235846#comment-17235846 ] Reid Chan commented on HBASE-25308: --- Let's do that. > [branch-1] Consume Guava from hbase-thirdparty

[jira] [Commented] (HBASE-25308) [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

2020-11-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235641#comment-17235641 ] Andrew Kyle Purtell commented on HBASE-25308: - [~reidchan] > [branch-1] Consume Guava from