[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355905#comment-17355905 ] Hudson commented on HBASE-25932: Results for branch branch-2 [build #267 on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355740#comment-17355740 ] Hudson commented on HBASE-25932: Results for branch master [build #312 on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355449#comment-17355449 ] Hudson commented on HBASE-25932: Results for branch branch-2.4 [build #132 on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353339#comment-17353339 ] Rushabh Shah commented on HBASE-25932: -- [~bharathv] Thank you for the rough patch. I think the

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353331#comment-17353331 ] Viraj Jasani commented on HBASE-25932: -- While closing WAL,

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353251#comment-17353251 ] Viraj Jasani commented on HBASE-25932: -- {code:java} AsyncWriter temp =

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352918#comment-17352918 ] Bharath Vissapragada commented on HBASE-25932: -- Wrote a quick patch to test an approach and

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352872#comment-17352872 ] Bharath Vissapragada commented on HBASE-25932: -- Yes, I agree there is a race with AsyncWAL

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352721#comment-17352721 ] Andrew Kyle Purtell commented on HBASE-25932: - I have reopened HBASE-25924. We shouldn't

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352693#comment-17352693 ] Rushabh Shah commented on HBASE-25932: -- > When I tried locally with above changes in place on

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352635#comment-17352635 ] Viraj Jasani commented on HBASE-25932: -- {code:java} if (!isFirst) { // Re-compute the file

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352630#comment-17352630 ] Rushabh Shah commented on HBASE-25932: -- > Btw if you revert reading wal size in ProtobufLogReader,

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352628#comment-17352628 ] Viraj Jasani commented on HBASE-25932: -- Hmm, let me take a detailed look tomorrow. Btw if you

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352610#comment-17352610 ] Rushabh Shah commented on HBASE-25932: -- But what the EOF exceptions that we might encounter in

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352590#comment-17352590 ] Viraj Jasani commented on HBASE-25932: -- I meant test case only since we can't be sure about wait

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352574#comment-17352574 ] Rushabh Shah commented on HBASE-25932: -- [~vjasani] Thank you for the feedback. Are you suggesting

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352564#comment-17352564 ] Viraj Jasani commented on HBASE-25932: -- Anyway we can wait till WAL is closed before append and

[jira] [Commented] (HBASE-25932) TestWALEntryStream#testCleanClosedWALs test is failing.

[ https://issues.apache.org/jira/browse/HBASE-25932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352479#comment-17352479 ] Rushabh Shah commented on HBASE-25932: -- [~apurt...@yahoo.com]  [~vjasani]  [~busbey]  [~bharathv]