[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-07-13 Thread Lijin Bin (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379851#comment-17379851
 ] 

Lijin Bin commented on HBASE-26013:
---

The patch for branch-2 is different with master. 

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369173#comment-17369173
 ] 

Hudson commented on HBASE-26013:


Results for branch branch-2.4
[build #150 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/150/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/150/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/150/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/150/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/150/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369001#comment-17369001
 ] 

Hudson commented on HBASE-26013:


Results for branch branch-2
[build #285 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/285//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-24 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368953#comment-17368953
 ] 

Hudson commented on HBASE-26013:


Results for branch branch-2.3
[build #243 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/243/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/243/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/243/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/243/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/243/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 1.7.1, 2.4.5
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-24 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368695#comment-17368695
 ] 

Reid Chan commented on HBASE-26013:
---

Cherry-picked to branch-2.3 & branch-2.4 as well.

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0, 1.7.1
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367461#comment-17367461
 ] 

Hudson commented on HBASE-26013:


Results for branch branch-1
[build #137 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/137/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/137//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/137//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/137//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.1
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367310#comment-17367310
 ] 

Hudson commented on HBASE-26013:


Results for branch master
[build #329 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/329/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/329/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/329/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/329/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.1
>
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366987#comment-17366987
 ] 

Reid Chan commented on HBASE-26013:
---

Can you provide patches for other branches? thx

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>  Components: metrics
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Major
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-21 Thread Yutong Xiao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366476#comment-17366476
 ] 

Yutong Xiao commented on HBASE-26013:
-

Both table level and RS level.

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-06-20 Thread Anoop Sam John (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366366#comment-17366366
 ] 

Anoop Sam John commented on HBASE-26013:


An issue with table level read metric right?  RS level metric update regression 
also in place?

> Get operations readRows metrics becomes zero after HBASE-25677
> --
>
> Key: HBASE-26013
> URL: https://issues.apache.org/jira/browse/HBASE-26013
> Project: HBase
>  Issue Type: Bug
>Reporter: Yutong Xiao
>Assignee: Yutong Xiao
>Priority: Minor
>
> After HBASE-25677, Server+table counters on each scan are extracted from 
> #nextRaw to rsServices scan. In this case, the get operation will not count 
> the read rows. So that the readRows metrics becomes zero. Should add counter 
> in metricsUpdateForGet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)