[jira] [Commented] (HBASE-26046) [JDK17] Add a JDK17 profile
[ https://issues.apache.org/jira/browse/HBASE-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562708#comment-17562708 ] Ramón García Fernández commented on HBASE-26046: One does not really need a profile specific for JDK 17. All the flags here can be used with JDK 11 , and adding a new profile adds unnecessary complexity. > [JDK17] Add a JDK17 profile > --- > > Key: HBASE-26046 > URL: https://issues.apache.org/jira/browse/HBASE-26046 > Project: HBase > Issue Type: Sub-task >Reporter: Wei-Chiu Chuang >Priority: Major > > While HBase builds fine with JDK17, tests fail because a number of Java SDK > modules are no longer exposed to unnamed modules by default. We need to open > them up. > Without which, the tests fail for errors like: > {noformat} > [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.469 > s <<< FAILURE! - in org.apache.hadoop.hbase.rest.model.TestNamespacesModel > [ERROR] org.apache.hadoop.hbase.rest.model.TestNamespacesModel.testBuildModel > Time elapsed: 0.273 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make > protected final java.lang.Class > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws > java.lang.ClassFormatError accessible: module java.base does not "opens > java.lang" to unnamed module @56ef9176 > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-26046) [JDK17] Add a JDK17 profile
[ https://issues.apache.org/jira/browse/HBASE-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483558#comment-17483558 ] Wei-Chiu Chuang commented on HBASE-26046: - I had worked on it but it's a shame I thought the PR was up for review. You would need these for JDK17: https://github.com/jojochuang/hbase/commit/b909db7ca7c221308ad5aba1ea58317c77358b94 I'm tied up with the log4j stuff right now so wont' be able to continue on it. Feel free to pick this up [~ndimiduk] > [JDK17] Add a JDK17 profile > --- > > Key: HBASE-26046 > URL: https://issues.apache.org/jira/browse/HBASE-26046 > Project: HBase > Issue Type: Sub-task >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > > While HBase builds fine with JDK17, tests fail because a number of Java SDK > modules are no longer exposed to unnamed modules by default. We need to open > them up. > Without which, the tests fail for errors like: > {noformat} > [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.469 > s <<< FAILURE! - in org.apache.hadoop.hbase.rest.model.TestNamespacesModel > [ERROR] org.apache.hadoop.hbase.rest.model.TestNamespacesModel.testBuildModel > Time elapsed: 0.273 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make > protected final java.lang.Class > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws > java.lang.ClassFormatError accessible: module java.base does not "opens > java.lang" to unnamed module @56ef9176 > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26046) [JDK17] Add a JDK17 profile
[ https://issues.apache.org/jira/browse/HBASE-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482711#comment-17482711 ] Nick Dimiduk commented on HBASE-26046: -- A colleague started down this path and has reported back. At least the following {{--add-opens}} are required. {noformat} --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED {noformat} > [JDK17] Add a JDK17 profile > --- > > Key: HBASE-26046 > URL: https://issues.apache.org/jira/browse/HBASE-26046 > Project: HBase > Issue Type: Sub-task >Reporter: Wei-Chiu Chuang >Assignee: Wei-Chiu Chuang >Priority: Major > > While HBase builds fine with JDK17, tests fail because a number of Java SDK > modules are no longer exposed to unnamed modules by default. We need to open > them up. > Without which, the tests fail for errors like: > {noformat} > [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.469 > s <<< FAILURE! - in org.apache.hadoop.hbase.rest.model.TestNamespacesModel > [ERROR] org.apache.hadoop.hbase.rest.model.TestNamespacesModel.testBuildModel > Time elapsed: 0.273 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make > protected final java.lang.Class > java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws > java.lang.ClassFormatError accessible: module java.base does not "opens > java.lang" to unnamed module @56ef9176 > at > org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001)