[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391032#comment-17391032 ] Hudson commented on HBASE-26105: Results for branch branch-2 [build #311 on

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391015#comment-17391015 ] Hudson commented on HBASE-26105: Results for branch branch-2.3 [build #267 on

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-31 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390972#comment-17390972 ] Hudson commented on HBASE-26105: Results for branch master [build #357 on

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-30 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390841#comment-17390841 ] Hudson commented on HBASE-26105: Results for branch branch-2.4 [build #172 on

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-30 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17390583#comment-17390583 ] Duo Zhang commented on HBASE-26105: --- OK, seems reasonable. We have computeIfPresent call, which is

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-23 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385966#comment-17385966 ] Yutong Xiao commented on HBASE-26105: - I think that is the purpose of the containsBlock method of

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-22 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385890#comment-17385890 ] Yutong Xiao commented on HBASE-26105: - While L1 may have victim handler, if just getBlock on L1, it

[jira] [Commented] (HBASE-26105) Rectify the expired TODO comment in CombinedBC

2021-07-22 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385274#comment-17385274 ] Duo Zhang commented on HBASE-26105: --- Why not just call getBlock on l1Cache and check if it is null? >