[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394421#comment-17394421
 ] 

Hudson commented on HBASE-26160:


Results for branch branch-2.4
[build #175 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/175/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/175/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/175/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/175/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394248#comment-17394248
 ] 

Hudson commented on HBASE-26160:


Results for branch branch-2
[build #314 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/314//console].


> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394044#comment-17394044
 ] 

Hudson commented on HBASE-26160:


Results for branch master
[build #360 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/360/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/360/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/360/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/360/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-05 Thread Bryan Beaudreault (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393941#comment-17393941
 ] 

Bryan Beaudreault commented on HBASE-26160:
---

Done, thanks to you both for the reviews

> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-04 Thread Anoop Sam John (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393581#comment-17393581
 ] 

Anoop Sam John commented on HBASE-26160:


Pls fill the Release Notes with new config and how to use it. Tks

> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-02 Thread Bryan Beaudreault (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391513#comment-17391513
 ] 

Bryan Beaudreault commented on HBASE-26160:
---

Good point [~anoop.hbase]. I was thinking you'd have to explicitly reference 
each logger, but I just pushed a commit so that we do a startsWith check 
instead of equals. This should work more like how log4j log levels work.

> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-01 Thread Anoop Sam John (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391312#comment-17391312
 ] 

Anoop Sam John commented on HBASE-26160:


Whether the deny list should take some pattern instead of exact names?  In PR 
we see to check for equality.
What if org.apache.hadoop.hbase.security.access is in deny list but one try to 
set Log level for org.apache.hadoop.hbase.security.access.AccessController ?

> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels

2021-08-01 Thread Bryan Beaudreault (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391171#comment-17391171
 ] 

Bryan Beaudreault commented on HBASE-26160:
---

Linked PR adds a new configuration hbase.ui.logLevels.readonly.loggers, which 
accepts a comma separated list of loggers which cannot be modified by the 
logLevel page. Results in an error like this:

 
h2. HTTP ERROR 403 Modification of logger 
org.apache.hadoop.hbase.security.access not allowed.
||URI:|/logLevel|
||STATUS:|403|
||MESSAGE:|Modification of logger org.apache.hadoop.hbase.security.access not 
allowed.|
||SERVLET:|logLevel|

> Configurable disallowlist for live editing of loglevels
> ---
>
> Key: HBASE-26160
> URL: https://issues.apache.org/jira/browse/HBASE-26160
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
>
> We currently use log4j/slf4j for audit logging in AccessController. This is 
> convenient but presents a security/compliance risk because we allow 
> live-editing of logLevels via the UI. One can simply set the logger to OFF 
> and then perform actions un-audited.
> We should add a configuration for setting certain log levels to read-only



--
This message was sent by Atlassian Jira
(v8.3.4#803005)