[jira] [Commented] (HBASE-26223) Splitted WAL files are deleted rather than archiving them

2021-08-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404496#comment-17404496
 ] 

Pankaj Kumar commented on HBASE-26223:
--

Not complete backport, HBASE-24632 enables procedure-based WAL split by default 
which we shouldn't do for patch releases. I will raise PR with the required 
changes only.

> Splitted WAL files are deleted rather than archiving them
> -
>
> Key: HBASE-26223
> URL: https://issues.apache.org/jira/browse/HBASE-26223
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.2.7, 2.3.6
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> When procedure based WAL split is enabled, we are deleting splitted WAL files 
> immediately rather than moving to archive path.
>  
> https://github.com/apache/hbase/blob/67e9c6422d6d5b39586ffe529f55b76d8b8939ff/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALRemoteProcedure.java#L99



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26223) Splitted WAL files are deleted rather than archiving them

2021-08-25 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404473#comment-17404473
 ] 

Duo Zhang commented on HBASE-26223:
---

Let's back port to 2.3?

> Splitted WAL files are deleted rather than archiving them
> -
>
> Key: HBASE-26223
> URL: https://issues.apache.org/jira/browse/HBASE-26223
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.2.7, 2.3.6
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> When procedure based WAL split is enabled, we are deleting splitted WAL files 
> immediately rather than moving to archive path.
>  
> https://github.com/apache/hbase/blob/67e9c6422d6d5b39586ffe529f55b76d8b8939ff/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALRemoteProcedure.java#L99



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-26223) Splitted WAL files are deleted rather than archiving them

2021-08-25 Thread Pankaj Kumar (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404472#comment-17404472
 ] 

Pankaj Kumar commented on HBASE-26223:
--

HBASE-24632 already fixed this issue in branch-2.4+. 

> Splitted WAL files are deleted rather than archiving them
> -
>
> Key: HBASE-26223
> URL: https://issues.apache.org/jira/browse/HBASE-26223
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.2.7, 2.3.6
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Critical
>
> When procedure based WAL split is enabled, we are deleting splitted WAL files 
> immediately rather than moving to archive path.
>  
> https://github.com/apache/hbase/blob/67e9c6422d6d5b39586ffe529f55b76d8b8939ff/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALRemoteProcedure.java#L99



--
This message was sent by Atlassian Jira
(v8.3.4#803005)