[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501877#comment-17501877
 ] 

Hudson commented on HBASE-26691:


Results for branch branch-2
[build #476 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/476/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/476/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/476/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/476/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/476/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.6.0, 2.4.11
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501870#comment-17501870
 ] 

Hudson commented on HBASE-26691:


Results for branch branch-2.4
[build #301 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/301/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/301/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/301/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/301/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/301/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.6.0, 2.4.11
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-03-05 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501811#comment-17501811
 ] 

Hudson commented on HBASE-26691:


Results for branch branch-2.5
[build #56 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/56/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/56/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/56/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/56/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/56/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.6.0, 2.4.11
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-03-04 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501536#comment-17501536
 ] 

Andrew Kyle Purtell commented on HBASE-26691:
-

I also committed an addendum that ups the reload4j version to the latest 
release at this time, 1.2.19, and fixes a couple of misses in shading and 
assembly configuration. 

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.6.0, 2.4.11
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-02-25 Thread Andrew Kyle Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498266#comment-17498266
 ] 

Andrew Kyle Purtell commented on HBASE-26691:
-

Approved the PR with some minor comments. Apologies for the delay in review. 

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.6.0
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Wei-Chiu Chuang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479838#comment-17479838
 ] 

Wei-Chiu Chuang commented on HBASE-26691:
-

There's a DISCUSS thread in Hadoop's dev ML. We should start one in HBase's dev 
ML.

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Wei-Chiu Chuang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479836#comment-17479836
 ] 

Wei-Chiu Chuang commented on HBASE-26691:
-

The reload4j is a drop-in replacement of log4j1. 

Although in reality, the shading makes it not so trivial as it sounds...

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Duo Zhang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479809#comment-17479809
 ] 

Duo Zhang commented on HBASE-26691:
---

The logj41 shim is not enough to make hadoop work. It does not include all the 
appender implementations but there are several customized appender 
implementations so at least, when running UTs we will fail with class not 
found...

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479788#comment-17479788
 ] 

Sean Busbey commented on HBASE-26691:
-

(if there was a DISCUSS thread I've overlooked please point me there)

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Sean Busbey (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479787#comment-17479787
 ] 

Sean Busbey commented on HBASE-26691:
-

What's the tradeoff compared to using the log4j 1 shim provided by the asf 
logging pmc?

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (HBASE-26691) Replacing log4j with reload4j for branch-2.x

2022-01-20 Thread Wei-Chiu Chuang (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479781#comment-17479781
 ] 

Wei-Chiu Chuang commented on HBASE-26691:
-

+1

> Replacing log4j with reload4j for branch-2.x
> 
>
> Key: HBASE-26691
> URL: https://issues.apache.org/jira/browse/HBASE-26691
> Project: HBase
>  Issue Type: Task
>  Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Critical
> Fix For: 2.5.0, 2.4.10
>
>
> There are several new CVEs for log4j1 now.
> As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace 
> the log4j1 dependencies with reload4j.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)