[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801971#comment-17801971
]
Becker Ewing commented on HBASE-27730:
--
Sorry about that! I've pushed up the code to this branch:
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801968#comment-17801968
]
Bryan Beaudreault commented on HBASE-27730:
---
Can you attach the full benchmark? Looks like
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801953#comment-17801953
]
Becker Ewing commented on HBASE-27730:
--
{noformat}
Benchmark (shouldUseNoneRecycler)
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801952#comment-17801952
]
Bryan Beaudreault commented on HBASE-27730:
---
Could you try running my exact patch with your
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801950#comment-17801950
]
Becker Ewing commented on HBASE-27730:
--
Yeah what I have is pretty similar. I just attached a patch
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801947#comment-17801947
]
Bryan Beaudreault commented on HBASE-27730:
---
Unfortunately, I can't find the benchmark I had.
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801944#comment-17801944
]
Becker Ewing commented on HBASE-27730:
--
[~zhangduo] / [~bbeaudreault] any chance that y'all have
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701791#comment-17701791
]
Duo Zhang commented on HBASE-27730:
---
Let's go with the null check solution first. Copying
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701773#comment-17701773
]
Bryan Beaudreault commented on HBASE-27730:
---
[~zhangduo] I tested it out copying
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701774#comment-17701774
]
Bryan Beaudreault commented on HBASE-27730:
---
Good idea, that makes sense for sure.
> Optimize
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701767#comment-17701767
]
Duo Zhang commented on HBASE-27730:
---
I prefer to implement deallocate like this
{code}
Recycler r =
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701755#comment-17701755
]
Bryan Beaudreault commented on HBASE-27730:
---
I wasn't sure if we wanted to go down that path
[
https://issues.apache.org/jira/browse/HBASE-27730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17701740#comment-17701740
]
Duo Zhang commented on HBASE-27730:
---
I think we could copy the code in AbstractReferenceCounted into
13 matches
Mail list logo
