[jira] [Commented] (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258736#comment-13258736 ] Phabricator commented on HBASE-3508: mbautin has committed the revision "[jira] [HBASE-3508] [89-fb] LruBlockCache statistics thread should have a name". REVISION DETAIL https://reviews.facebook.net/D2853 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1328561 > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Fix For: 0.90.1 > > Attachments: D2853.1.patch, D2853.2.patch, D2853.3.patch, > hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256004#comment-13256004 ] Phabricator commented on HBASE-3508: Liyin has accepted the revision "[jira] [HBASE-3508] [89-fb] LruBlockCache statistics thread should have a name". LGTM:) One minor comment. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:129 May set it as a daemon thread here REVISION DETAIL https://reviews.facebook.net/D2853 BRANCH lrublockcache_statistics_thread_should_have_a_HBASE-3508 > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Fix For: 0.90.1 > > Attachments: D2853.1.patch, hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991796#comment-12991796 ] Hudson commented on HBASE-3508: --- Integrated in HBase-TRUNK #1737 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1737/]) > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Fix For: 0.90.1 > > Attachments: hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991600#comment-12991600 ] stack commented on HBASE-3508: -- Thats fine by me. > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Attachments: hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991599#comment-12991599 ] Todd Lipcon commented on HBASE-3508: Hrm, I don't see a convenient way of getting the RS name from within LruBlockCache without breaking some of the layer encapsulation we've got going on (a dependency backwards from HFile -> RS seems ugly) How about commit as is and some day maybe we do an improvement? :) > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Attachments: hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3508) LruBlockCache statistics thread should have a name
[ https://issues.apache.org/jira/browse/HBASE-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991591#comment-12991591 ] stack commented on HBASE-3508: -- Patch is good. +1 on commit. FYI, there used to be a bit of a convention naming threads where thread would be prefixed by main thread name. In this case it would be something like regionserver60020 (If you thread dump you see regionserver60020.compactor, regionserver60020.majorCompactionChecker", regionserver60020.leaseChecker", etc.). You might want to keep up the tradition when you commit. > LruBlockCache statistics thread should have a name > -- > > Key: HBASE-3508 > URL: https://issues.apache.org/jira/browse/HBASE-3508 > Project: HBase > Issue Type: Improvement >Reporter: Todd Lipcon >Assignee: Todd Lipcon >Priority: Trivial > Attachments: hbase-3508.txt > > > Currently it's just an unnamed threadpool. It's annoying. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
