[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174961#comment-13174961
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175013#comment-13175013
]
Zhihong Yu commented on HBASE-4218:
---
Please remove the last hunk from
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175021#comment-13175021
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175258#comment-13175258
]
Zhihong Yu commented on HBASE-4218:
---
Hadoop QA remembers attachment Id and wouldn't
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174401#comment-13174401
]
Phabricator commented on HBASE-4218:
tedyu has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174586#comment-13174586
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174590#comment-13174590
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174621#comment-13174621
]
Zhihong Yu commented on HBASE-4218:
---
TestHeapSize.testSizes error should be caused by
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174641#comment-13174641
]
Phabricator commented on HBASE-4218:
mcorgan has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173514#comment-13173514
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173764#comment-13173764
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173792#comment-13173792
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173865#comment-13173865
]
Zhihong Yu commented on HBASE-4218:
---
Thanks for the nice work, Mikhail.
{code}
1 out of
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172872#comment-13172872
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171648#comment-13171648
]
Phabricator commented on HBASE-4218:
Kannan has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171662#comment-13171662
]
Phabricator commented on HBASE-4218:
Kannan has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169613#comment-13169613
]
Phabricator commented on HBASE-4218:
Kannan has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169621#comment-13169621
]
Phabricator commented on HBASE-4218:
tedyu has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169741#comment-13169741
]
Phabricator commented on HBASE-4218:
Kannan has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169842#comment-13169842
]
Mikhail Bautin commented on HBASE-4218:
---
bq. Maybe we could call it
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169860#comment-13169860
]
Phabricator commented on HBASE-4218:
stack has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169894#comment-13169894
]
Matt Corgan commented on HBASE-4218:
Another thought I had was that all reading and
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169981#comment-13169981
]
stack commented on HBASE-4218:
--
@Matt Thats a reasonable point re: naming and your latter
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169987#comment-13169987
]
Matt Corgan commented on HBASE-4218:
Shoehorn is probably the right term, but yeah, i
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169989#comment-13169989
]
stack commented on HBASE-4218:
--
Then I'd say that if you managed to make your trie
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168935#comment-13168935
]
Zhihong Yu commented on HBASE-4218:
---
There are two files which need to be refreshed:
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168970#comment-13168970
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168996#comment-13168996
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167721#comment-13167721
]
Phabricator commented on HBASE-4218:
mbautin has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13167784#comment-13167784
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168115#comment-13168115
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168165#comment-13168165
]
Phabricator commented on HBASE-4218:
stack has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159391#comment-13159391
]
Phabricator commented on HBASE-4218:
tedyu has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159531#comment-13159531
]
Phabricator commented on HBASE-4218:
todd has commented on the revision [jira]
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159045#comment-13159045
]
Hadoop QA commented on HBASE-4218:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159048#comment-13159048
]
Ted Yu commented on HBASE-4218:
---
HadoopQA isn't functioning as usual.
Manual execution of
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150197#comment-13150197
]
Ted Yu commented on HBASE-4218:
---
I went over some of my earlier comments and found that
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127079#comment-13127079
]
jirapos...@reviews.apache.org commented on HBASE-4218:
--
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127185#comment-13127185
]
Matt Corgan commented on HBASE-4218:
I'm trying to hook the prefix trie code into
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127238#comment-13127238
]
Ted Yu commented on HBASE-4218:
---
I think similar change (as suggested by Matt) for
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123704#comment-13123704
]
Ted Yu commented on HBASE-4218:
---
There seems to be a typo in the comment of KeyValue.java:
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123709#comment-13123709
]
Ted Yu commented on HBASE-4218:
---
HFileBlockDeltaEncoder.java, RedundantKVGenerator.java,
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123785#comment-13123785
]
Ted Yu commented on HBASE-4218:
---
For BlockDeltaEncoder.decodeDataBlock():
{code}
private
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123792#comment-13123792
]
Ted Yu commented on HBASE-4218:
---
For BlockDeltaEncoder.inMemory:
{code}
private final
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123799#comment-13123799
]
Ted Yu commented on HBASE-4218:
---
For BlockDeltaEncoder.useEncodedScanner(), why doesn't
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123510#comment-13123510
]
jirapos...@reviews.apache.org commented on HBASE-4218:
--
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123576#comment-13123576
]
Ted Yu commented on HBASE-4218:
---
For BlockDeltaEncoder.afterBlockCache(), I am not sure if
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123597#comment-13123597
]
Ted Yu commented on HBASE-4218:
---
EmptyBlockDeltaEncoder, CompressionState, BlockDeltaEncoder
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123330#comment-13123330
]
jirapos...@reviews.apache.org commented on HBASE-4218:
--
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123337#comment-13123337
]
Jacek Migdal commented on HBASE-4218:
-
Performance results on production data.
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123366#comment-13123366
]
jirapos...@reviews.apache.org commented on HBASE-4218:
--
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121752#comment-13121752
]
Matt Corgan commented on HBASE-4218:
Jacek - have you done anything with the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088827#comment-13088827
]
Jacek Migdal commented on HBASE-4218:
-
Regarding variable byte encoding. There is also
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088266#comment-13088266
]
Matt Corgan commented on HBASE-4218:
I lean towards byte-encoding ints whenever
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087805#comment-13087805
]
stack commented on HBASE-4218:
--
I was reading a paper this morning and it was going on about
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087538#comment-13087538
]
stack commented on HBASE-4218:
--
/me hearts this issue
Delta Encoding of KeyValues (aka
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086545#comment-13086545
]
Ted Yu commented on HBASE-4218:
---
bq. Moreover, it should allow far more efficient seeking
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086556#comment-13086556
]
Jacek Migdal commented on HBASE-4218:
-
Yes, I plan to measure seek performance within
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086574#comment-13086574
]
Matt Corgan commented on HBASE-4218:
Sorry I haven't chimed in on this in a while, but
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086634#comment-13086634
]
Matt Corgan commented on HBASE-4218:
That sounds great Jacek. Let me know how to get
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086650#comment-13086650
]
Jacek Migdal commented on HBASE-4218:
-
So far the implemented interface looks like:
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086704#comment-13086704
]
Matt Corgan commented on HBASE-4218:
I should be able to work with ByteBuffer as the
[
https://issues.apache.org/jira/browse/HBASE-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086708#comment-13086708
]
Jonathan Gray commented on HBASE-4218:
--
bq. in the mean time there will be places it
63 matches
Mail list logo