[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[
https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166048#comment-13166048
]
nkeywal commented on HBASE-4610:
There is a side effect: the mini cluster needs 4,5 seconds to start
{noformat}
2011-12-09 01:30:37,883 INFO [SplitLogWorker-localhost,39827,1323423035986]
regionserver.SplitLogWorker(140): SplitLogWorker localhost,39827,1323423035986
starting
2011-12-09 01:30:37,961 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,062 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,163 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,264 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,365 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,467 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,568 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,668 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,769 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,870 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:38,971 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,072 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,173 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,274 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,375 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,476 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,577 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,678 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,779 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,881 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:39,981 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,082 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,183 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,284 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,385 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,486 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,587 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,688 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
currently=1
2011-12-09 01:30:40,789 INFO [Master:0;localhost,35818,1323423035631]
master.ServerManager(557): Waiting on regionserver(s) count to settle;
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166343#comment-13166343 ] nkeywal commented on HBASE-4610: I will fix this in HBASE-4993 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166417#comment-13166417 ] stack commented on HBASE-4610: -- I'd doubt it. IIRC, we're supposed to move on w/ the regionservers that we have after the timeout. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165089#comment-13165089 ] Hudson commented on HBASE-4610: --- Integrated in HBase-TRUNK #2526 (See [https://builds.apache.org/job/HBase-TRUNK/2526/]) HBASE-4610 Addendum removes break statement HBASE-4610 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk tedyu : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java tedyu : Files : * /hbase/trunk/CHANGES.txt * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164682#comment-13164682 ] Hadoop QA commented on HBASE-4610: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506499/4610.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -160 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 72 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/463//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/463//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/463//console This message is automatically generated. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.1 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164772#comment-13164772 ] Hadoop QA commented on HBASE-4610: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506517/4610.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -160 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 72 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/467//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/467//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/467//console This message is automatically generated. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.1 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164785#comment-13164785 ] Zhihong Yu commented on HBASE-4610: --- Test suite passes. Will commit later today if no objections. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.1 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[
https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164835#comment-13164835
]
Jonathan Hsieh commented on HBASE-4610:
---
I had started doing this also -- are you sure you want to keep the 'if (count
== oldcount count 0) break' line? It was removed on the 0.90 version.
{code}
+long slept = 0;
for (int oldcount = countOfRegionServers(); !this.master.isStopped();) {
Thread.sleep(interval);
+ slept += interval;
count = countOfRegionServers();
if (count == oldcount count 0) break;
String msg;
+ if (count == oldcount count = minToStart slept = timeout) {
+LOG.info(Finished waiting for regionserver count to settle; +
+count= + count + , sleptFor= + slept);
+break;
{code}
Before and after test, TestMasterFailover seemed flaky for me on the 0.92
branch.
Is the plan for this 0.92.0 or 0.92.1?
Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk
(definitely bring in config params, decide if we need to do more to fix the
bug)
-
Key: HBASE-4610
URL: https://issues.apache.org/jira/browse/HBASE-4610
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.92.0, 0.94.0
Reporter: Jonathan Gray
Assignee: Jonathan Gray
Fix For: 0.92.1
Attachments: 4610.txt
Over in HBASE-3380 we were having some TestMasterFailover flakiness. We
added some more config parameters to better control the master startup loop
where it waits for RS to heartbeat in. We had thought at the time that 92
would have a different solution but it is still relying on heartbeats to
learn about RSs.
For now, we should definitely bring these config params into 92/trunk.
Otherwise this is an incompatible regression and adding these will also make
things like what was just reported over in HBASE-4603 trivial to fix in an
optimal way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164839#comment-13164839 ] Zhihong Yu commented on HBASE-4610: --- Thanks for the review Jonathan. The first break statement should be removed. I ran TestMasterFailover on MacBook and didn't see failure. I think this should go to 0.92.0 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.1 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164844#comment-13164844 ] Jonathan Hsieh commented on HBASE-4610: --- I think if the tests are no worse than before, 0.92.0 sounds reasonable to me. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164853#comment-13164853 ] stack commented on HBASE-4610: -- +1 on include in 0.92. Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164967#comment-13164967 ] Hudson commented on HBASE-4610: --- Integrated in HBase-0.92 #176 (See [https://builds.apache.org/job/HBase-0.92/176/]) HBASE-4610 Addendum removes break statement HBASE-4610 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk tedyu : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java tedyu : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165009#comment-13165009 ] Hudson commented on HBASE-4610: --- Integrated in HBase-0.92-security #33 (See [https://builds.apache.org/job/HBase-0.92-security/33/]) HBASE-4610 Addendum removes break statement HBASE-4610 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk tedyu : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java tedyu : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13165038#comment-13165038 ] Hudson commented on HBASE-4610: --- Integrated in HBase-TRUNK-security #25 (See [https://builds.apache.org/job/HBase-TRUNK-security/25/]) HBASE-4610 Addendum removes break statement HBASE-4610 Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk tedyu : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java tedyu : Files : * /hbase/trunk/CHANGES.txt * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0, 0.94.0 Attachments: 4610.txt Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149094#comment-13149094 ] Ted Yu commented on HBASE-4610: --- Since HBASE-4749 has been integrated, is this still needed ? Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Fix For: 0.92.0 Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4610) Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug)
[ https://issues.apache.org/jira/browse/HBASE-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134798#comment-13134798 ] stack commented on HBASE-4610: -- Any update on this one? Port HBASE-3380 (Master failover can split logs of live servers) to 92/trunk (definitely bring in config params, decide if we need to do more to fix the bug) - Key: HBASE-4610 URL: https://issues.apache.org/jira/browse/HBASE-4610 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.92.0, 0.94.0 Reporter: Jonathan Gray Assignee: Jonathan Gray Priority: Critical Fix For: 0.92.0 Over in HBASE-3380 we were having some TestMasterFailover flakiness. We added some more config parameters to better control the master startup loop where it waits for RS to heartbeat in. We had thought at the time that 92 would have a different solution but it is still relying on heartbeats to learn about RSs. For now, we should definitely bring these config params into 92/trunk. Otherwise this is an incompatible regression and adding these will also make things like what was just reported over in HBASE-4603 trivial to fix in an optimal way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
