[jira] [Commented] (HBASE-4635) Remove dependency of java for rpm/deb packaging

2011-11-04 Thread Hadoop QA (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144491#comment-13144491
 ] 

Hadoop QA commented on HBASE-4635:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502540/HBASE-4635-1.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 javadoc.  The javadoc tool appears to have generated -164 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 46 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
  org.apache.hadoop.hbase.client.TestAdmin
  org.apache.hadoop.hbase.master.TestMasterFailover

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/180//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/180//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/180//console

This message is automatically generated.

 Remove dependency of java for rpm/deb packaging
 ---

 Key: HBASE-4635
 URL: https://issues.apache.org/jira/browse/HBASE-4635
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.92.0
 Environment: Java, Ubuntu, RHEL
Reporter: Eric Yang
Assignee: Eric Yang
 Attachments: HBASE-4635-1.patch, HBASE-4635.patch


 Comment from HBASE-3606:
 Eric, it looks like hbase rpm spec file sets dependency on jdk. Can we remove 
 the jdk dependency ? As everyone will not be installing jdk through rpm.
 There are multiple ways to install Java on Linux.  It would be better to 
 remove Java dependency declaration for packaging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4635) Remove dependency of java for rpm/deb packaging

2011-11-02 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142288#comment-13142288
 ] 

stack commented on HBASE-4635:
--

This has this change:

{code}
 . /etc/default/hadoop-env.sh
-. /etc/default/zookeeper-env.sh
{code}

... which is a little unrelated.  You are trying to make this hbase-env.sh same 
as the original?

 Remove dependency of java for rpm/deb packaging
 ---

 Key: HBASE-4635
 URL: https://issues.apache.org/jira/browse/HBASE-4635
 Project: HBase
  Issue Type: Improvement
  Components: build
Affects Versions: 0.92.0
 Environment: Java, Ubuntu, RHEL
Reporter: Eric Yang
Assignee: Eric Yang
 Attachments: HBASE-4635.patch


 Comment from HBASE-3606:
 Eric, it looks like hbase rpm spec file sets dependency on jdk. Can we remove 
 the jdk dependency ? As everyone will not be installing jdk through rpm.
 There are multiple ways to install Java on Linux.  It would be better to 
 remove Java dependency declaration for packaging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira