[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[ https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161783#comment-13161783 ] Phabricator commented on HBASE-4795: mbautin has abandoned the revision [jira] [HBASE-4795] Fix TestHFileBlock when running on a 32-bit JVM. The diff was committed, abandoning. REVISION DETAIL https://reviews.facebook.net/D459 Fix TestHFileBlock when running on a 32-bit JVM --- Key: HBASE-4795 URL: https://issues.apache.org/jira/browse/HBASE-4795 Project: HBase Issue Type: Bug Reporter: Mikhail Bautin Assignee: Mikhail Bautin Priority: Minor Fix For: 0.94.0 Attachments: D459.1.patch, D459.2.patch, Fix-TestHFileBlock-heap-size-test-on-a-32-bit-JVM.patch Our Hudson test server seems to run a 32-bit JVM. This patch fixes TestHFileBlock to work correctly for both 64-bit and 32-bit JVM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[ https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150966#comment-13150966 ] Hadoop QA commented on HBASE-4795: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503827/D459.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/260//console This message is automatically generated. Fix TestHFileBlock when running on a 32-bit JVM --- Key: HBASE-4795 URL: https://issues.apache.org/jira/browse/HBASE-4795 Project: HBase Issue Type: Bug Reporter: Mikhail Bautin Assignee: Mikhail Bautin Priority: Minor Attachments: D459.1.patch Our Hudson test server seems to run a 32-bit JVM. This patch fixes TestHFileBlock to work correctly for both 64-bit and 32-bit JVM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[
https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150973#comment-13150973
]
Phabricator commented on HBASE-4795:
stack has accepted the revision [jira] [HBASE-4795] Fix TestHFileBlock when
running on a 32-bit JVM.
Good on you Mikhail. Patch looks good. Put it up in JIRA and I'll commit.
I started to look at this. Doing this to the pom will make the test run w/
32bit jvm so you can confirm your fix (if that helps):
h-25-20:hbase stack$ git diff pom.xml
diff --git a/pom.xml b/pom.xml
index 2847416..ec6a9fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -569,6 +569,7 @@
parallel${myParallel}/parallel
perCoreThreadCountfalse/perCoreThreadCount
threadCount${myThreadCount}/threadCount
+argLine-d32/argLine
includes
include${unittest.include}/include
/includes
REVISION DETAIL
https://reviews.facebook.net/D459
Fix TestHFileBlock when running on a 32-bit JVM
---
Key: HBASE-4795
URL: https://issues.apache.org/jira/browse/HBASE-4795
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Priority: Minor
Attachments: D459.1.patch, D459.2.patch
Our Hudson test server seems to run a 32-bit JVM. This patch fixes
TestHFileBlock to work correctly for both 64-bit and 32-bit JVM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[ https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151000#comment-13151000 ] Hadoop QA commented on HBASE-4795: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503828/D459.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -163 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/261//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/261//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/261//console This message is automatically generated. Fix TestHFileBlock when running on a 32-bit JVM --- Key: HBASE-4795 URL: https://issues.apache.org/jira/browse/HBASE-4795 Project: HBase Issue Type: Bug Reporter: Mikhail Bautin Assignee: Mikhail Bautin Priority: Minor Fix For: 0.94.0 Attachments: D459.1.patch, D459.2.patch, Fix-TestHFileBlock-heap-size-test-on-a-32-bit-JVM.patch Our Hudson test server seems to run a 32-bit JVM. This patch fixes TestHFileBlock to work correctly for both 64-bit and 32-bit JVM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[ https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151010#comment-13151010 ] Hadoop QA commented on HBASE-4795: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503832/Fix-TestHFileBlock-heap-size-test-on-a-32-bit-JVM.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -163 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 51 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/262//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/262//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/262//console This message is automatically generated. Fix TestHFileBlock when running on a 32-bit JVM --- Key: HBASE-4795 URL: https://issues.apache.org/jira/browse/HBASE-4795 Project: HBase Issue Type: Bug Reporter: Mikhail Bautin Assignee: Mikhail Bautin Priority: Minor Fix For: 0.94.0 Attachments: D459.1.patch, D459.2.patch, Fix-TestHFileBlock-heap-size-test-on-a-32-bit-JVM.patch Our Hudson test server seems to run a 32-bit JVM. This patch fixes TestHFileBlock to work correctly for both 64-bit and 32-bit JVM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4795) Fix TestHFileBlock when running on a 32-bit JVM
[ https://issues.apache.org/jira/browse/HBASE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151077#comment-13151077 ] Hudson commented on HBASE-4795: --- Integrated in HBase-TRUNK #2446 (See [https://builds.apache.org/job/HBase-TRUNK/2446/]) HBASE-4795 Fix TestHFileBlock when running on a 32-bit JVM stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaConfigured.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java Fix TestHFileBlock when running on a 32-bit JVM --- Key: HBASE-4795 URL: https://issues.apache.org/jira/browse/HBASE-4795 Project: HBase Issue Type: Bug Reporter: Mikhail Bautin Assignee: Mikhail Bautin Priority: Minor Fix For: 0.94.0 Attachments: D459.1.patch, D459.2.patch, Fix-TestHFileBlock-heap-size-test-on-a-32-bit-JVM.patch Our Hudson test server seems to run a 32-bit JVM. This patch fixes TestHFileBlock to work correctly for both 64-bit and 32-bit JVM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
