[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490437#comment-13490437 ] Hudson commented on HBASE-5256: --- Integrated in HBase-0.92-security #146 (See [https://builds.apache.org/job/HBase-0.92-security/146/]) HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407) Result = FAILURE > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488572#comment-13488572 ] Hudson commented on HBASE-5256: --- Integrated in HBase-0.92 #601 (See [https://builds.apache.org/job/HBase-0.92/601/]) HBASE-7072 HBase-5256 breaks 0.92-0.94 compatibility (Himanshu) (Revision 1404407) Result = FAILURE > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Ted Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254267#comment-13254267 ] Zhihong Yu commented on HBASE-5256: --- See discussion on HBASE-5795. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254263#comment-13254263 ] Lars Hofhansl commented on HBASE-5256: -- Or does it now? I think that affects the public interface. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254262#comment-13254262 ] Lars Hofhansl commented on HBASE-5256: -- I see. This needs to be reverted from the 0.94 branch, otherwise it breaks compatibility with 0.92. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254228#comment-13254228 ] Zhihong Yu commented on HBASE-5256: --- I agree this is not needed for 0.94 > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197586#comment-13197586 ] stack commented on HBASE-5256: -- Yes. Upgrading. Seems like it'd be easy to make this self-migrating. Would suggest we do it. Make a new issue? > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197507#comment-13197507 ] Hudson commented on HBASE-5256: --- Integrated in HBase-TRUNK #2649 (See [https://builds.apache.org/job/HBase-TRUNK/2649/]) HBASE-5256 Use WritableUtils.readVInt() in RegionLoad.readFields() (Mubarak) tedyu : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197476#comment-13197476 ] Zhihong Yu commented on HBASE-5256: --- @Stack: The patch is only for TRUNK. Are you concerned with upgrading from 0.90/0.92 to 0.94 ? > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197475#comment-13197475 ] stack commented on HBASE-5256: -- Will we have to be careful with this patch? It can't go into a minor version, right else you could have a regionserver reporting a master metrics in a format it can't interpret (or vice versa, the master will be expecting them as longs but they come over as vlongs). We up the version on HServerLoad but don't exploit the version change. We could have had HSL self-migrate reading using old code if it got a v1 HSL to deserialize. Then we could have this in a point version. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197411#comment-13197411 ] Zhihong Yu commented on HBASE-5256: --- Integrated to TRUNK. Thanks for the patch Mubarak. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197132#comment-13197132 ] Zhihong Yu commented on HBASE-5256: --- Will integrate the patch if there is no objection. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[
https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196560#comment-13196560
]
Zhihong Yu commented on HBASE-5256:
---
{code}
Running org.apache.hadoop.hbase.replication.TestReplicationPeer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.53 sec
{code}
TestReplicationPeer passed locally on my MacBook.
Patch looks good.
> Use WritableUtils.readVInt() in RegionLoad.readFields()
> ---
>
> Key: HBASE-5256
> URL: https://issues.apache.org/jira/browse/HBASE-5256
> Project: HBase
> Issue Type: Task
>Reporter: Zhihong Yu
>Assignee: Mubarak Seyed
> Fix For: 0.94.0
>
> Attachments: HBASE-5256.trunk.v1.patch
>
>
> Currently in.readInt() is used in RegionLoad.readFields()
> More metrics would be added to RegionLoad in the future, we should utilize
> WritableUtils.readVInt() to reduce the amount of data exchanged between
> Master and region servers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196557#comment-13196557 ] Hadoop QA commented on HBASE-5256: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512491/HBASE-5256.trunk.v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -140 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationPeer org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/877//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/877//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/877//console This message is automatically generated. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-5256.trunk.v1.patch > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195646#comment-13195646 ] Mubarak Seyed commented on HBASE-5256: -- Waiting for corporate approval to contribute this patch. Thanks. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191683#comment-13191683 ] Zhihong Yu commented on HBASE-5256: --- Since the version of RegionLoad would be bumped, I think this change should be applied to all integer/long metrics. > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu > Fix For: 0.94.0 > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5256) Use WritableUtils.readVInt() in RegionLoad.readFields()
[ https://issues.apache.org/jira/browse/HBASE-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191676#comment-13191676 ] Lars Hofhansl commented on HBASE-5256: -- Should we recommend this only for new metrics (in order to avoid more wire incompatibilities? > Use WritableUtils.readVInt() in RegionLoad.readFields() > --- > > Key: HBASE-5256 > URL: https://issues.apache.org/jira/browse/HBASE-5256 > Project: HBase > Issue Type: Task >Reporter: Zhihong Yu > Fix For: 0.94.0 > > > Currently in.readInt() is used in RegionLoad.readFields() > More metrics would be added to RegionLoad in the future, we should utilize > WritableUtils.readVInt() to reduce the amount of data exchanged between > Master and region servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
