[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197019#comment-13197019
]
Zhihong Yu commented on HBASE-5290:
---
Integrated to TRUNK.
Thanks for the patch, Ben.
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197506#comment-13197506
]
Hudson commented on HBASE-5290:
---
Integrated in HBase-TRUNK #2649 (See
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196335#comment-13196335
]
Zhihong Yu commented on HBASE-5290:
---
This is not recommended:
{code}
-import
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196344#comment-13196344
]
Zhihong Yu commented on HBASE-5290:
---
I did get an assertion without the patch to
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196372#comment-13196372
]
Hadoop QA commented on HBASE-5290:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196370#comment-13196370
]
Zhihong Yu commented on HBASE-5290:
---
@Liyin:
Do you mind if I assign this JIRA to Ben ?
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196399#comment-13196399
]
Hadoop QA commented on HBASE-5290:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196405#comment-13196405
]
Zhihong Yu commented on HBASE-5290:
---
Patch looks good.
{code}
+ public final Object
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196420#comment-13196420
]
Ben West commented on HBASE-5290:
-
@Zhihong: fine with me. I was thinking it would be good
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196441#comment-13196441
]
Hadoop QA commented on HBASE-5290:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196461#comment-13196461
]
Ben West commented on HBASE-5290:
-
TestCompactSelection is a different package, so making
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196468#comment-13196468
]
Zhihong Yu commented on HBASE-5290:
---
Good point.
When the need comes to access
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196483#comment-13196483
]
Ben West commented on HBASE-5290:
-
v4 looks good to me. +1.
[FindBugs]
[
https://issues.apache.org/jira/browse/HBASE-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196485#comment-13196485
]
Zhihong Yu commented on HBASE-5290:
---
Will integrate tomorrow if there is no further
14 matches
Mail list logo
