[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570938#comment-13570938 ] Hudson commented on HBASE-5458: --- Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571099#comment-13571099 ] Hudson commented on HBASE-5458: --- Integrated in HBase-0.92-security #148 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561705#comment-13561705 ] Hudson commented on HBASE-5458: --- Integrated in HBase-0.94-security #96 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557451#comment-13557451 ] Elliott Clark commented on HBASE-5458: -- This is called on every hfile reader open, so

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557458#comment-13557458 ] Lars Hofhansl commented on HBASE-5458: -- AbstractFSReader.decompress is called for

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557478#comment-13557478 ] Elliott Clark commented on HBASE-5458: -- Yeah you're correct. every block not every

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557485#comment-13557485 ] Elliott Clark commented on HBASE-5458: -- going ahead to commit then.

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557488#comment-13557488 ] Lars Hofhansl commented on HBASE-5458: -- +1 Thread safety issues

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557559#comment-13557559 ] Hudson commented on HBASE-5458: --- Integrated in HBase-TRUNK #3766 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557599#comment-13557599 ] Hudson commented on HBASE-5458: --- Integrated in HBase-0.94 #746 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557741#comment-13557741 ] Hudson commented on HBASE-5458: --- Integrated in HBase-0.92 #611 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557799#comment-13557799 ] Hudson commented on HBASE-5458: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #360 (See

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556068#comment-13556068 ] Jonathan Hsieh commented on HBASE-5458: --- I didn't look at all the context, but why

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556312#comment-13556312 ] Elliott Clark commented on HBASE-5458: -- The lock's transient so that if someone tries

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556335#comment-13556335 ] Jonathan Hsieh commented on HBASE-5458: --- I'm fine with the double checked locking.

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556342#comment-13556342 ] David McIntosh commented on HBASE-5458: --- This patch prevents instantiating the same

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556399#comment-13556399 ] Ted Yu commented on HBASE-5458: --- {code} +

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556506#comment-13556506 ] Ted Yu commented on HBASE-5458: --- Latest patch looks good. Can you prepare patch for trunk ?

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556537#comment-13556537 ] Jonathan Hsieh commented on HBASE-5458: --- [~eclark] lgtm +1. [~dmcintosh] it looks

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556545#comment-13556545 ] Elliott Clark commented on HBASE-5458: -- [~yuzhih...@gmail.com] Sure I'll post a

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556610#comment-13556610 ] Jonathan Hsieh commented on HBASE-5458: --- Got it, thanks for the clarification (I was

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556739#comment-13556739 ] Hadoop QA commented on HBASE-5458: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556758#comment-13556758 ] Hadoop QA commented on HBASE-5458: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556824#comment-13556824 ] Hadoop QA commented on HBASE-5458: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556828#comment-13556828 ] Ted Yu commented on HBASE-5458: --- +1 on latest patch. Thread safety issues

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556858#comment-13556858 ] Elliott Clark commented on HBASE-5458: -- [~lhofhansl] Thoughts on this in 0.94 ?

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556872#comment-13556872 ] Lars Hofhansl commented on HBASE-5458: -- Looks good to me. This is not on a hot code

[jira] [Commented] (HBASE-5458) Thread safety issues with Compression.Algorithm.GZ and CompressionTest

[ https://issues.apache.org/jira/browse/HBASE-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13214068#comment-13214068 ] Zhihong Yu commented on HBASE-5458: --- {code} try { Compressor c =