[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-11-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490364#comment-13490364 ] Hudson commented on HBASE-5547: --- Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-11-04 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490464#comment-13490464 ] Jesse Yates commented on HBASE-5547: Looks like this was a spurious notification - it

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-11-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489093#comment-13489093 ] Hudson commented on HBASE-5547: --- Integrated in HBase-0.94 #565 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-14 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13455986#comment-13455986 ] Jesse Yates commented on HBASE-5547: Also, ran the added tests and they passed

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13455990#comment-13455990 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-14 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456276#comment-13456276 ] Ted Yu commented on HBASE-5547: --- Trunk patch was integrated in July. According to Todd, we

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-14 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13456287#comment-13456287 ] Jesse Yates commented on HBASE-5547: @Ted - yeah, I was thinking the same thing about

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-04 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447854#comment-13447854 ] Jesse Yates commented on HBASE-5547: @Matteo - TimeToLiveHFileCleaner.instantiateFS()

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-09-03 Thread Matteo Bertozzi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447408#comment-13447408 ] Matteo Bertozzi commented on HBASE-5547: Can we add preChore() and postChore() to

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424027#comment-13424027 ] Jesse Yates commented on HBASE-5547: @Ted how much worse in terms of NN overhead would

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424051#comment-13424051 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424083#comment-13424083 ] Zhihong Ted Yu commented on HBASE-5547: --- If you want to add an extra check for file

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424088#comment-13424088 ] Zhihong Ted Yu commented on HBASE-5547: --- Addendum v4 integrated to trunk.

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424138#comment-13424138 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK #3178 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424218#comment-13424218 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #113 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420574#comment-13420574 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #106 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420118#comment-13420118 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420159#comment-13420159 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #103 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420187#comment-13420187 ] Zhihong Ted Yu commented on HBASE-5547: --- For the NPE, I think the null reference

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420226#comment-13420226 ] Jesse Yates commented on HBASE-5547: {quote} Meaning either sf.getPath() or

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420233#comment-13420233 ] Zhihong Ted Yu commented on HBASE-5547: --- bq. we don't have to worry about

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420235#comment-13420235 ] Jesse Yates commented on HBASE-5547: bq. The failure was due to

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420237#comment-13420237 ] Zhihong Ted Yu commented on HBASE-5547: --- Could this be related to HBASE-6403 ?

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420250#comment-13420250 ] Jesse Yates commented on HBASE-5547: bq. Could this be related to HBASE-6403 ?

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420266#comment-13420266 ] Jesse Yates commented on HBASE-5547: {quote} Users may choose to enable the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420269#comment-13420269 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420271#comment-13420271 ] Lars Hofhansl commented on HBASE-5547: -- Addendum v1 looks good to me. I also agree

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420272#comment-13420272 ] Jesse Yates commented on HBASE-5547: {quote} When would the passed configuration to

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420275#comment-13420275 ] Lars Hofhansl commented on HBASE-5547: -- I see... Seems something else is wrong then,

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420279#comment-13420279 ] Jesse Yates commented on HBASE-5547: I'd rather have the fix in, then revert as

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420280#comment-13420280 ] Jesse Yates commented on HBASE-5547: oh, wait, spent the two minutes to RTFS and

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420284#comment-13420284 ] Lars Hofhansl commented on HBASE-5547: -- Yeah, separate ticket. Should we commit v1 as

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420285#comment-13420285 ] Jesse Yates commented on HBASE-5547: The catalog janitor is just one more line. I'll

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420293#comment-13420293 ] Zhihong Ted Yu commented on HBASE-5547: --- bq. Because the cleaner chain works, the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420296#comment-13420296 ] Jesse Yates commented on HBASE-5547: @Ted: yeah. In the worst case, the data is kept

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420305#comment-13420305 ] Zhihong Ted Yu commented on HBASE-5547: --- If I keep the cleaner in addendum v1,

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420310#comment-13420310 ] Jesse Yates commented on HBASE-5547: @Ted yes, the sleeps for the ttl cleaner were

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420312#comment-13420312 ] Lars Hofhansl commented on HBASE-5547: -- @Ted: The two cleaners should be tested in

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420329#comment-13420329 ] Jesse Yates commented on HBASE-5547: Attached fix for the fs scheme to HBASE-6441.

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420349#comment-13420349 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420350#comment-13420350 ] Zhihong Ted Yu commented on HBASE-5547: --- From

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420419#comment-13420419 ] Jesse Yates commented on HBASE-5547: Sounds good to me. Don't delete

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420423#comment-13420423 ] Lars Hofhansl commented on HBASE-5547: -- Addendum v3 looks good to me. I'm happy to

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420425#comment-13420425 ] Zhihong Ted Yu commented on HBASE-5547: --- @Lars: Go ahead. Don't

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420427#comment-13420427 ] Lars Hofhansl commented on HBASE-5547: -- Done. Should we file an extra jira and a

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420429#comment-13420429 ] Zhihong Ted Yu commented on HBASE-5547: --- HBASE-6442 has been filed as a sub-task of

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420434#comment-13420434 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420449#comment-13420449 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK #3162 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-21 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419756#comment-13419756 ] Jesse Yates commented on HBASE-5547: bq. I find that deleteRegion() was addressed, but

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420095#comment-13420095 ] Hudson commented on HBASE-5547: --- Integrated in HBase-TRUNK #3158 (See

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-21 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420097#comment-13420097 ] Lars Hofhansl commented on HBASE-5547: -- Hmm... From the failed run: {quote} Results :

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419207#comment-13419207 ] Zhihong Ted Yu commented on HBASE-5547: --- Will integrate in 3 hours if there is no

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419696#comment-13419696 ] Lars Hofhansl commented on HBASE-5547: -- +1 on patch. Ted pinged me, that he is out

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419697#comment-13419697 ] Jesse Yates commented on HBASE-5547: @Lars I don't think it would be all that

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419723#comment-13419723 ] Lars Hofhansl commented on HBASE-5547: -- I also verified in a real setup, that an

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419724#comment-13419724 ] Lars Hofhansl commented on HBASE-5547: -- Ok. On more question I asked just now on RB:

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419725#comment-13419725 ] Lars Hofhansl commented on HBASE-5547: -- Or is it that all region are first deleted

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419746#comment-13419746 ] Zhihong Ted Yu commented on HBASE-5547: --- I think the latest patch has addressed

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-20 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419748#comment-13419748 ] Lars Hofhansl commented on HBASE-5547: -- True, but if dropping a table just drops the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418622#comment-13418622 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418690#comment-13418690 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-19 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418707#comment-13418707 ] Jesse Yates commented on HBASE-5547: Assuming changes between v15 and v16 are just

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-19 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418730#comment-13418730 ] Zhihong Ted Yu commented on HBASE-5547: --- I ran

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-18 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417366#comment-13417366 ] Zhihong Ted Yu commented on HBASE-5547: --- Here is the link about InterruptedException

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-18 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417664#comment-13417664 ] Jesse Yates commented on HBASE-5547: Something Matteo mentioned in the latest review:

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-18 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13417954#comment-13417954 ] Jesse Yates commented on HBASE-5547: bq. Question is if we want to scope this in this

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13418090#comment-13418090 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416737#comment-13416737 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-12 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412887#comment-13412887 ] Jesse Yates commented on HBASE-5547: {quote} 1. Don't delete the files, and the TTL

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-12 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413010#comment-13413010 ] Jesse Yates commented on HBASE-5547: {quote} My reservation to the 2nd part is that

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413267#comment-13413267 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-10 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411072#comment-13411072 ] Lars Hofhansl commented on HBASE-5547: -- I think we should break this up into two

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408778#comment-13408778 ] stack commented on HBASE-5547: -- Added some review up on rb. Don't delete

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-06 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408391#comment-13408391 ] Jesse Yates commented on HBASE-5547: Updated the diff on RB to the latest trunk. Any

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-07-06 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408547#comment-13408547 ] Lars Hofhansl commented on HBASE-5547: -- Will look at it this weekend!

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404032#comment-13404032 ] Jonathan Hsieh commented on HBASE-5547: --- RB please. Don't delete

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404048#comment-13404048 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404055#comment-13404055 ] Jesse Yates commented on HBASE-5547: Surprised that those tests are failing, looking

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404096#comment-13404096 ] Jesse Yates commented on HBASE-5547: @Ted: Because in the constructor it does {code}

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404114#comment-13404114 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404136#comment-13404136 ] Zhihong Ted Yu commented on HBASE-5547: --- https://reviews.apache.org/r/4633/ has been

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404304#comment-13404304 ] Zhihong Ted Yu commented on HBASE-5547: --- Currently hbase.master.cleaner.interval

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-29 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404309#comment-13404309 ] Jesse Yates commented on HBASE-5547: @Ted: you would still need to check the directory

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-27 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402412#comment-13402412 ] Jesse Yates commented on HBASE-5547: Anyone else have any objections to Lar's

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-21 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398776#comment-13398776 ] Lars Hofhansl commented on HBASE-5547: -- Rethinking the whole previous discussion...

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-21 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398782#comment-13398782 ] Jesse Yates commented on HBASE-5547: @Lars: I was thinking that we should have this

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13397815#comment-13397815 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-06-20 Thread Zhihong Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13397848#comment-13397848 ] Zhihong Ted Yu commented on HBASE-5547: --- @Jesse: HConstants.java has moved to

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-18 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279347#comment-13279347 ] Zhihong Yu commented on HBASE-5547: --- Looks like this JIRA would depend on HBASE-5991.

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-18 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279425#comment-13279425 ] Jesse Yates commented on HBASE-5547: HBASE-5991 would be nice, but not necessary.

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-13 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13274455#comment-13274455 ] Lars Hofhansl commented on HBASE-5547: -- Sorry for bringing this up again (Jesse you

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-10 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272727#comment-13272727 ] jirapos...@reviews.apache.org commented on HBASE-5547: --

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-10 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272756#comment-13272756 ] Zhihong Yu commented on HBASE-5547: --- @Jesse: Do you want to post latest patch here for

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-10 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272848#comment-13272848 ] jirapos...@reviews.apache.org commented on HBASE-5547: --

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272882#comment-13272882 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-10 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273057#comment-13273057 ] Jesse Yates commented on HBASE-5547: test flapped locally for me, but got it to pass.

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13265851#comment-13265851 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266013#comment-13266013 ] Hadoop QA commented on HBASE-5547: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-01 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266081#comment-13266081 ] Jesse Yates commented on HBASE-5547: arg! Thought I had resolved the concurrency issue

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in backup mode

2012-05-01 Thread jirapos...@reviews.apache.org (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266190#comment-13266190 ] jirapos...@reviews.apache.org commented on HBASE-5547: --

  1   2   >