[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233551#comment-13233551 ] ramkrishna.s.vasudevan commented on HBASE-5593: --- @Ted Patch wise its ok with me. If there are no other places this fix should go, then I am +1 on this. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233596#comment-13233596 ] ramkrishna.s.vasudevan commented on HBASE-5593: --- @David Can you create a patch without prefix for committing it? Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233685#comment-13233685 ] David S. Wang commented on HBASE-5593: -- There is no prefix on this patch. Note that this patch only applies to 0.90 branch as that is the only branch that has this problem. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233867#comment-13233867 ] David S. Wang commented on HBASE-5593: -- Stack, Looks like you left in the TestMaster change, and left out the TestStrings change. Is that what you meant? I'm fine either way; just want to make sure this is what you meant. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: 5593-v2.txt, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233892#comment-13233892 ] stack commented on HBASE-5593: -- Thanks David. Should be fixed now. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: 5593-v2.txt, 5593-v3.txt, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[
https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232439#comment-13232439
]
Zhihong Yu commented on HBASE-5593:
---
Thanks for adding the test.
{code}
+ * Copyright 2012 The Apache Software Foundation
{code}
Year isn't needed above.
{code}
+assertEquals(Strings.domainNamePointerToHostName(hbase.apache.org.),
hbase.apache.org);
{code}
Please wrap long line above.
Reverse DNS resolution in regionServerStartup() does not strip trailing dot
---
Key: HBASE-5593
URL: https://issues.apache.org/jira/browse/HBASE-5593
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.90.6
Reporter: David S. Wang
Assignee: David S. Wang
Fix For: 0.90.7
Attachments: HBASE-5593-2.patch, HBASE-5593.patch
HBASE-4109 covered the removal of trailing dots in PTR records from reverse
DNS lookups. We seem to have missed a case in HMaster#regionServerStartup().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232447#comment-13232447 ] Hadoop QA commented on HBASE-5593: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518868/HBASE-5593-3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1223//console This message is automatically generated. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232448#comment-13232448 ] Zhihong Yu commented on HBASE-5593: --- Thanks for the quick turn-around. Was the patch generated based on latest trunk ? Please fix patch application conflict. For testMasterOnlineRegions(), can we give it a better name ? It only tests whether the name of host conforms to certain criterion. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[
https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232449#comment-13232449
]
Zhihong Yu commented on HBASE-5593:
---
One more thing, please label TestStrings class with:
{code}
@Category(SmallTests.class)
{code}
Reverse DNS resolution in regionServerStartup() does not strip trailing dot
---
Key: HBASE-5593
URL: https://issues.apache.org/jira/browse/HBASE-5593
Project: HBase
Issue Type: Bug
Components: master
Affects Versions: 0.90.6
Reporter: David S. Wang
Assignee: David S. Wang
Fix For: 0.90.7
Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch
HBASE-4109 covered the removal of trailing dots in PTR records from reverse
DNS lookups. We seem to have missed a case in HMaster#regionServerStartup().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232454#comment-13232454 ] David S. Wang commented on HBASE-5593: -- Ted, The patch is meant to be applied to 0.90.x branch only. The QA robot tries to apply to trunk even though I marked this bug as only for 0.90.x, so it will fail the application. Also, I do not see any @Category tags in 0.90.x branch tests, though I see them in trunk. Do you still want me to add this tag? I will change the name of the test to testMasterOnlineRegionsCorrectFormat and upload a new patch with that change as soon as I get a response to the two aforementioned observations. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232458#comment-13232458 ] Zhihong Yu commented on HBASE-5593: --- @David: Sorry for the comment about test category - I forgot this is for 0.90 only. How about naming testMasterOnlineRegions() testCorrectHostnameFormat() ? You can append ForOnlineRegions at the end if you want. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593-2.patch, HBASE-5593-3.patch, HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232466#comment-13232466 ] Zhihong Yu commented on HBASE-5593: --- @Stack, @Ram: Please comment on latest patch. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13232467#comment-13232467 ] Hadoop QA commented on HBASE-5593: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518870/HBASE-5593.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1224//console This message is automatically generated. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231363#comment-13231363 ] Hadoop QA commented on HBASE-5593: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518698/HBASE-5593.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1206//console This message is automatically generated. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231370#comment-13231370 ] David S. Wang commented on HBASE-5593: -- This will not apply to trunk as the robot is trying to do, because the fix is only applicable to 0.90.x. Also, I can add a test case if necessary, though I think the fix is fairly obvious in this case. Let me know. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231551#comment-13231551 ] stack commented on HBASE-5593: -- @Ted You mean a unit test for the Strings.domainNamePointerToHostName facility? (We don't want to test InetSocketAddress). Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231698#comment-13231698 ] stack commented on HBASE-5593: -- That is given directly to Strings.domainNamePointerToHostName so you would like a test that shows that if a dot suffix, domainNamePointerToHostName will drop it? That should be enough? Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5593) Reverse DNS resolution in regionServerStartup() does not strip trailing dot
[ https://issues.apache.org/jira/browse/HBASE-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13231738#comment-13231738 ] Zhihong Yu commented on HBASE-5593: --- Yes. Reverse DNS resolution in regionServerStartup() does not strip trailing dot --- Key: HBASE-5593 URL: https://issues.apache.org/jira/browse/HBASE-5593 Project: HBase Issue Type: Bug Components: master Affects Versions: 0.90.6 Reporter: David S. Wang Assignee: David S. Wang Fix For: 0.90.7 Attachments: HBASE-5593.patch HBASE-4109 covered the removal of trailing dots in PTR records from reverse DNS lookups. We seem to have missed a case in HMaster#regionServerStartup(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
