[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2013-01-02 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542235#comment-13542235 ] Jimmy Xiang commented on HBASE-5620: I thought about that. It is a clean choice to

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2013-01-02 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542245#comment-13542245 ] stack commented on HBASE-5620: -- [~jxiang] I've been experimenting over in HBASE-6521

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-12-28 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540656#comment-13540656 ] Jimmy Xiang commented on HBASE-5620: There is no special reason other than that our

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-12-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540670#comment-13540670 ] stack commented on HBASE-5620: -- [~jxiang] BlockingInterface has references to RpcController

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-27 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263742#comment-13263742 ] Jimmy Xiang commented on HBASE-5620: Yes, I was thinking to eliminate the conversion

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-26 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262742#comment-13262742 ] Zhihong Yu commented on HBASE-5620: --- Is there plan to adopt various measures to counter

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262017#comment-13262017 ] Jimmy Xiang commented on HBASE-5620: I did some testing with YCSB. I loaded 9000 rows

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-25 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262176#comment-13262176 ] Todd Lipcon commented on HBASE-5620: Hey Jimmy. Any difference on throughput?

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262193#comment-13262193 ] Jimmy Xiang commented on HBASE-5620: Yes, the throughput is also degraded. Without

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-25 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262203#comment-13262203 ] Todd Lipcon commented on HBASE-5620: That sounds like you only ran YCSB with 1

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13262216#comment-13262216 ] Jimmy Xiang commented on HBASE-5620: You are right. I used just one thread. This can

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-19 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257264#comment-13257264 ] Hudson commented on HBASE-5620: --- Integrated in HBase-TRUNK-security #175 (See

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-18 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256897#comment-13256897 ] Hudson commented on HBASE-5620: --- Integrated in HBase-TRUNK #2781 (See

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-17 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1324#comment-1324 ] Zhihong Yu commented on HBASE-5620: --- @Stack: Do you think the addendum is ready to be

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-17 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255667#comment-13255667 ] stack commented on HBASE-5620: -- @Jimmy So every invocation will throw an exception? {code} +

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-17 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255704#comment-13255704 ] Jimmy Xiang commented on HBASE-5620: @Stack, not every invocation will throw an

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-17 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13255778#comment-13255778 ] stack commented on HBASE-5620: -- I made HBASE-5810 to apply this Jimmy. Good stuff.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-16 Thread Todd Lipcon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254961#comment-13254961 ] Todd Lipcon commented on HBASE-5620: Did anyone do any benchmarks here? It concerns me

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-16 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254979#comment-13254979 ] Jimmy Xiang commented on HBASE-5620: I did some testing with YCSB (mostly inserts).

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-15 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254360#comment-13254360 ] Jimmy Xiang commented on HBASE-5620: Thanks for reviewing. Both regular test suite and

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254153#comment-13254153 ] Jimmy Xiang commented on HBASE-5620: @Stack, thanks. @Ted, I am looking into it now.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254215#comment-13254215 ] Hadoop QA commented on HBASE-5620: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254216#comment-13254216 ] Jimmy Xiang commented on HBASE-5620: TestForceCacheImportantBlocks is green for me.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-14 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13254258#comment-13254258 ] Zhihong Yu commented on HBASE-5620: --- Addendum makes sense. TestAccessControlFilter

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253169#comment-13253169 ] Hadoop QA commented on HBASE-5620: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253377#comment-13253377 ] Jimmy Xiang commented on HBASE-5620: I will take a look at the test failures.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253513#comment-13253513 ] Hadoop QA commented on HBASE-5620: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253538#comment-13253538 ] Jimmy Xiang commented on HBASE-5620: TestWALPlayer passed for me. I didn't have the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253708#comment-13253708 ] stack commented on HBASE-5620: -- It passed for me. Let me commit this monster.

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253712#comment-13253712 ] stack commented on HBASE-5620: -- I think

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253714#comment-13253714 ] stack commented on HBASE-5620: -- Mind opening new issues Jimmy to do outstanding work like

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253781#comment-13253781 ] Zhihong Yu commented on HBASE-5620: --- Looks like trunk build failed with: {code} [ERROR]

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253799#comment-13253799 ] Jimmy Xiang commented on HBASE-5620: @Stack, I will move ClientProtocol.java and

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253802#comment-13253802 ] Zhihong Yu commented on HBASE-5620: --- Here is the command Jenkins used: {code} [trunk] $

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253840#comment-13253840 ] Jimmy Xiang commented on HBASE-5620: I ran Apache Rat check like mvn apache-rat:check,

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253843#comment-13253843 ] stack commented on HBASE-5620: -- I did too and trunk is also no longer complaining. The rat

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread Jimmy Xiang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253852#comment-13253852 ] Jimmy Xiang commented on HBASE-5620: @Stack, thanks a lot! I moved them to top-level

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253974#comment-13253974 ] stack commented on HBASE-5620: -- @Jimmy I think this is the biggest patch ever applied to

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-13 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13253975#comment-13253975 ] stack commented on HBASE-5620: -- @Jimmy I think this is the biggest patch ever applied to

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252613#comment-13252613 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252617#comment-13252617 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252619#comment-13252619 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252622#comment-13252622 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252623#comment-13252623 ] jirapos...@reviews.apache.org commented on HBASE-5620: --

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252687#comment-13252687 ] Hadoop QA commented on HBASE-5620: -- +1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-12 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252990#comment-13252990 ] Hadoop QA commented on HBASE-5620: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-11 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251719#comment-13251719 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-11 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252005#comment-13252005 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-11 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252035#comment-13252035 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-11 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252072#comment-13252072 ] jirapos...@reviews.apache.org commented on HBASE-5620: --

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248772#comment-13248772 ] jirapos...@reviews.apache.org commented on HBASE-5620: --

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249006#comment-13249006 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249054#comment-13249054 ] jirapos...@reviews.apache.org commented on HBASE-5620: --

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249075#comment-13249075 ] jirapos...@reviews.apache.org commented on HBASE-5620: -- bq. On

[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

2012-04-03 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245888#comment-13245888 ] jirapos...@reviews.apache.org commented on HBASE-5620: --