[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240467#comment-13240467 ] Jonathan Hsieh commented on HBASE-5642: --- The o.a.h.h.generated.master code looks to be generated from jsp's/jamon code and seems more potentially serious. From the warning there, that the string needs to be sanitized before being re-displayed (as opposed to being ignored). [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240472#comment-13240472 ] Uma Maheswara Rao G commented on HBASE-5642: I got you, Thanks a lot Jon for explanation. Lets committ the current patch in this JIRA if your reviews are ok. [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240474#comment-13240474 ] Jonathan Hsieh commented on HBASE-5642: --- Yup, I'm in the process of doing a quick test and committing. Thanks Uma! [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240902#comment-13240902 ] Hudson commented on HBASE-5642: --- Integrated in HBase-TRUNK #2697 (See [https://builds.apache.org/job/HBase-TRUNK/2697/]) HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/pom.xml [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Fix For: 0.96.0 Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241006#comment-13241006 ] Hudson commented on HBASE-5642: --- Integrated in HBase-TRUNK-security #153 (See [https://builds.apache.org/job/HBase-TRUNK-security/153/]) HBASE-5642 [findbugs] Exclude Thrift and Protobuf warnings (Uma Maheswara Rao G) (Revision 1306428) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/pom.xml [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Fix For: 0.96.0 Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239619#comment-13239619 ] Uma Maheswara Rao G commented on HBASE-5642: @Stack, attached the same patch from HBASE-5598. (Jon asked to move that patch here.) Patch added exclude filter file and added the thrift, protobuf packages to exclude list. Could you please take a look? [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239911#comment-13239911 ] stack commented on HBASE-5642: -- You are missing the avro generated files? [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240085#comment-13240085 ] Uma Maheswara Rao G commented on HBASE-5642: We don't have any comments from avro generated code. :-). I can see the comments only from org.apache.hadoop.hbase.generated.master. For this we have separate category of bug.HBASE-5649. I wanted to know one thing, whether we have rights to change the code under org.apache.hadoop.hbase.generated.master package? Anyway this question unrelated to this JIRA, but curious to know the fact.:-). If we are not allowed to change, I will exclude that package also in HBASE-5649. [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5642) [findbugs] Exclude Thrift and Protobuf warnings
[ https://issues.apache.org/jira/browse/HBASE-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240139#comment-13240139 ] Hadoop QA commented on HBASE-5642: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520157/HBASE-5642.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 13 javac compiler warnings (more than the trunk's current 5 warnings). +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1325//console This message is automatically generated. [findbugs] Exclude Thrift and Protobuf warnings --- Key: HBASE-5642 URL: https://issues.apache.org/jira/browse/HBASE-5642 Project: HBase Issue Type: Sub-task Components: build Affects Versions: 0.96.0 Reporter: Jonathan Hsieh Assignee: Uma Maheswara Rao G Attachments: HBASE-5642.patch, HBASE-5642.patch Exclude thrift and protobuf warnings since these are machine generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
