[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-11 Thread Uma Maheswara Rao G (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251809#comment-13251809 ] Uma Maheswara Rao G commented on HBASE-5645: Attached the same patch as David

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-11 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251855#comment-13251855 ] Hadoop QA commented on HBASE-5645: -- +1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250797#comment-13250797 ] Hadoop QA commented on HBASE-5645: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250801#comment-13250801 ] David S. Wang commented on HBASE-5645: -- TestReplication passed locally for me.

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250969#comment-13250969 ] jirapos...@reviews.apache.org commented on HBASE-5645: --

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251306#comment-13251306 ] David S. Wang commented on HBASE-5645: -- Not high priority obviously, but if someone

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251330#comment-13251330 ] Jonathan Hsieh commented on HBASE-5645: --- lgtm. I just checked in HBASE_5653 that

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Jonathan Hsieh (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251331#comment-13251331 ] Jonathan Hsieh commented on HBASE-5645: --- lgtm. I just checked in HBASE_5653 that

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Uma Maheswara Rao G (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251342#comment-13251342 ] Uma Maheswara Rao G commented on HBASE-5645: 1) ShutdownHook.java {code} if

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-10 Thread Uma Maheswara Rao G (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251353#comment-13251353 ] Uma Maheswara Rao G commented on HBASE-5645: Jon, I think #1 and #2 also need

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-05 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247621#comment-13247621 ] David S. Wang commented on HBASE-5645: -- OK I did get a timeout locally; I just didn't

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-05 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247660#comment-13247660 ] stack commented on HBASE-5645: -- See dev-support/findHangingTest.sh

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-05 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247730#comment-13247730 ] David S. Wang commented on HBASE-5645: -- Thanks for the pointer. Unfortunately, this

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-05 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247804#comment-13247804 ] Hadoop QA commented on HBASE-5645: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246454#comment-13246454 ] David S. Wang commented on HBASE-5645: -- Thanks for the review, Stack. Can this be

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246462#comment-13246462 ] stack commented on HBASE-5645: -- What you think of the hadoopqa failure David? Let me try

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246468#comment-13246468 ] David S. Wang commented on HBASE-5645: -- I didn't see any actual failures in the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246485#comment-13246485 ] Hadoop QA commented on HBASE-5645: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread David S. Wang (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246520#comment-13246520 ] David S. Wang commented on HBASE-5645: -- OK I see that the tests timedout.

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-04 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246526#comment-13246526 ] stack commented on HBASE-5645: -- That is the right command. Let me try it here locally.

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-03 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245862#comment-13245862 ] jirapos...@reviews.apache.org commented on HBASE-5645: --

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-03 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245881#comment-13245881 ] Hadoop QA commented on HBASE-5645: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5645) [findbugs] Fix correctness warnings

2012-04-03 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245898#comment-13245898 ] jirapos...@reviews.apache.org commented on HBASE-5645: --