[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251377#comment-13251377
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251462#comment-13251462
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250868#comment-13250868
]
Matteo Bertozzi commented on HBASE-5666:
The SOCKET_RETRY_WAIT_MS is 200ms but
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250889#comment-13250889
]
stack commented on HBASE-5666:
--
bq. If the client comes up during this time I think that
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250907#comment-13250907
]
Matteo Bertozzi commented on HBASE-5666:
{quote}
Does this need to be public? +
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250915#comment-13250915
]
stack commented on HBASE-5666:
--
@Matteo Mind trying what client does when no hbase root node?
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250927#comment-13250927
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250933#comment-13250933
]
Matteo Bertozzi commented on HBASE-5666:
@Stack The client crash with this message
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250941#comment-13250941
]
stack commented on HBASE-5666:
--
Should we admend the message to include 'Check the master is
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251056#comment-13251056
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251100#comment-13251100
]
Matteo Bertozzi commented on HBASE-5666:
@stack
do you mean, change the log
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251351#comment-13251351
]
stack commented on HBASE-5666:
--
Yes. That looks good. Let me retry against hadoopqa. A
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13251352#comment-13251352
]
stack commented on HBASE-5666:
--
I see that you don't have the above change in v7. You want
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13250269#comment-13250269
]
stack commented on HBASE-5666:
--
Patch looks good.
Logs '{
+
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248646#comment-13248646
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248666#comment-13248666
]
Matteo Bertozzi commented on HBASE-5666:
Since the logical flow is:
* HMaster
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249141#comment-13249141
]
Uma Maheswara Rao G commented on HBASE-5666:
Wrong JIRA...please ignore my
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246764#comment-13246764
]
Zhihong Yu commented on HBASE-5666:
---
For patch v5, please add javadoc for:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246804#comment-13246804
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246835#comment-13246835
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245720#comment-13245720
]
Matteo Bertozzi commented on HBASE-5666:
Still looking at the 0.90 code...
The new
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245734#comment-13245734
]
Zhihong Yu commented on HBASE-5666:
---
Patch v4 looks good. Minor comments below:
Since
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245758#comment-13245758
]
Matteo Bertozzi commented on HBASE-5666:
The problem that I see with the patch v4
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245759#comment-13245759
]
Matteo Bertozzi commented on HBASE-5666:
The problem that I see with the patch v4
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245795#comment-13245795
]
Zhihong Yu commented on HBASE-5666:
---
Interesting idea above.
+1 on removing special case
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244120#comment-13244120
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244471#comment-13244471
]
stack commented on HBASE-5666:
--
On creation of ZooKeeperWatcher, we do following. Why is it
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244488#comment-13244488
]
Matteo Bertozzi commented on HBASE-5666:
The problem here is that there's no
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244492#comment-13244492
]
stack commented on HBASE-5666:
--
This is the code that is supposed to create the base node
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244537#comment-13244537
]
Matteo Bertozzi commented on HBASE-5666:
m... maybe i've lost something but, in
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244560#comment-13244560
]
stack commented on HBASE-5666:
--
Thanks for digging. Seems like the RecoverableZK is failing
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244564#comment-13244564
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243845#comment-13243845
]
Ted Yu commented on HBASE-5666:
---
{code}
+if (keeperEx != null)
+ throw keeperEx;
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243855#comment-13243855
]
Matteo Bertozzi commented on HBASE-5666:
@Ted woo good catch
I've just translated
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243863#comment-13243863
]
Ted Yu commented on HBASE-5666:
---
Patch v2 looks good.
RegionServer doesn't
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243871#comment-13243871
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243902#comment-13243902
]
Hadoop QA commented on HBASE-5666:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243236#comment-13243236
]
Matteo Bertozzi commented on HBASE-5666:
diving into the code, I've also noticed
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243239#comment-13243239
]
Zhihong Yu commented on HBASE-5666:
---
Refactoring ZKUtil.waitForBaseZNode() so that it
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243296#comment-13243296
]
Zhihong Yu commented on HBASE-5666:
---
Patch makes sense.
Can you integrate it into
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243302#comment-13243302
]
Matteo Bertozzi commented on HBASE-5666:
I was thinking to patch
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243310#comment-13243310
]
Zhihong Yu commented on HBASE-5666:
---
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242684#comment-13242684
]
stack commented on HBASE-5666:
--
We used to retry our very first zk operation a few times
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242687#comment-13242687
]
Zhihong Yu commented on HBASE-5666:
---
I think we can introduce something similar to the
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242696#comment-13242696
]
stack commented on HBASE-5666:
--
Please be careful here.
What version of hbase are we talking
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242734#comment-13242734
]
Matteo Bertozzi commented on HBASE-5666:
The exception seems to be present in 0.92
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242796#comment-13242796
]
nkeywal commented on HBASE-5666:
I confirm I didn't modify this part in trunk. But who
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242801#comment-13242801
]
Matteo Bertozzi commented on HBASE-5666:
yep, just checked and the code seems
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240751#comment-13240751
]
Zhihong Yu commented on HBASE-5666:
---
@Matteo:
You're suggesting addition of a loop to
[
https://issues.apache.org/jira/browse/HBASE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240757#comment-13240757
]
Matteo Bertozzi commented on HBASE-5666:
@Zhihong Yu:
Probably a retry loop is the
50 matches
Mail list logo
