[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242508#comment-13242508
]
Zhihong Yu commented on HBASE-5667:
---
The new test failures are most likely inherited
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242521#comment-13242521
]
Zhihong Yu commented on HBASE-5667:
---
I think we should keep the Pattern.DOTALL in
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242531#comment-13242531
]
stack commented on HBASE-5667:
--
Yes, and call through to the other constructor so its
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242613#comment-13242613
]
Hadoop QA commented on HBASE-5667:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242615#comment-13242615
]
Zhihong Yu commented on HBASE-5667:
---
Patch v3 looks good.
Will integrate later if there
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242672#comment-13242672
]
Zhihong Yu commented on HBASE-5667:
---
Patch v3 integrated to TRUNK.
Thanks for the patch
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242701#comment-13242701
]
Hudson commented on HBASE-5667:
---
Integrated in HBase-TRUNK #2699 (See
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243041#comment-13243041
]
Hudson commented on HBASE-5667:
---
Integrated in HBase-TRUNK-security #155 (See
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241197#comment-13241197
]
David Arthur commented on HBASE-5667:
-
Anything needed from me to get this in?
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241835#comment-13241835
]
stack commented on HBASE-5667:
--
@Jimmy Whats going to happen in 0.96 serializing filters?
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241861#comment-13241861
]
Jimmy Xiang commented on HBASE-5667:
@Stack, I prefer to change them to pb so we
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241870#comment-13241870
]
Jimmy Xiang commented on HBASE-5667:
For this patch, it changes the constructor of
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241914#comment-13241914
]
Jimmy Xiang commented on HBASE-5667:
Pattern is fine if we can get it.
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13241940#comment-13241940
]
stack commented on HBASE-5667:
--
Yeah, it looks like we can do the String plus int for flags
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240753#comment-13240753
]
Zhihong Yu commented on HBASE-5667:
---
This is an incompatible change, right ?
{code}
-
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240778#comment-13240778
]
Hadoop QA commented on HBASE-5667:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240818#comment-13240818
]
David Arthur commented on HBASE-5667:
-
@Zhihong, yes it would be incompatible if it
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240839#comment-13240839
]
Zhihong Yu commented on HBASE-5667:
---
Maintaining backward compatibility would be
[
https://issues.apache.org/jira/browse/HBASE-5667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240978#comment-13240978
]
stack commented on HBASE-5667:
--
Patch looks good. We could commit it as is to trunk since
19 matches
Mail list logo
