[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256230#comment-13256230 ] Hudson commented on HBASE-5763: --- Integrated in HBase-TRUNK-security #174 (See [https://builds.apache.org/job/HBase-TRUNK-security/174/]) [jira] [HBASE-5763] Fix random failures in TestFSErrorsExposed Summary: TestFSErrorsExposed frequently fails due to unclean mini-cluster shutdown. Bringing datanodes back up, waiting for some time, and preemptively killing all regionservers and the master before shutdown. This is the trunk fix. The 89-fb patch is at D2739. Test Plan: Run TestFSErrorsExposed 100 times Reviewers: stack, tedyu, jdcryans, lhofhansl, jmhsieh, JIRA Reviewed By: tedyu Differential Revision: https://reviews.facebook.net/D2793 (Revision 1327337) Result = FAILURE mbautin : Files : * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, D2793.3.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256105#comment-13256105 ] Phabricator commented on HBASE-5763: mbautin has committed the revision "[jira] [HBASE-5763] Fix random failures in TestFSErrorsExposed". REVISION DETAIL https://reviews.facebook.net/D2793 COMMIT https://reviews.facebook.net/rHBASE1327337 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, D2793.3.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256100#comment-13256100 ] Phabricator commented on HBASE-5763: mbautin has commented on the revision "[jira] [HBASE-5763] Fix random failures in TestFSErrorsExposed". INLINE COMMENTS src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java:535 Done. REVISION DETAIL https://reviews.facebook.net/D2793 BRANCH fix_random_failures_in_testfserrorsexposed_HBASE-5763_v5 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, D2793.3.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256028#comment-13256028 ] Hadoop QA commented on HBASE-5763: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523031/D2793.3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1558//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1558//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1558//console This message is automatically generated. > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, D2793.3.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255184#comment-13255184 ] Hadoop QA commented on HBASE-5763: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522874/Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1546//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1546//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1546//console This message is automatically generated. > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255147#comment-13255147 ] Phabricator commented on HBASE-5763: tedyu has accepted the revision "[jira] [HBASE-5763] Fix random failures in TestFSErrorsExposed". INLINE COMMENTS src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java:535 It would be better if javadoc is added for the new public methods. REVISION DETAIL https://reviews.facebook.net/D2793 BRANCH fix_random_failures_in_testfserrorsexposed_HBASE-5763_v3 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, D2793.2.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch, > Fix-TestFSErrorsExposed-2012-04-16_15_41_24.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253977#comment-13253977 ] Phabricator commented on HBASE-5763: stack has commented on the revision "[jira] [HBASE-5763] [89-fb] Fix random failures in TestFSErrorsExposed". lgtm REVISION DETAIL https://reviews.facebook.net/D2739 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1326046 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253958#comment-13253958 ] Phabricator commented on HBASE-5763: mbautin has committed the revision "[jira] [HBASE-5763] [89-fb] Fix random failures in TestFSErrorsExposed". REVISION DETAIL https://reviews.facebook.net/D2739 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1326046 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253954#comment-13253954 ] Hadoop QA commented on HBASE-5763: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522651/D2793.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1521//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1521//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1521//console This message is automatically generated. > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch, D2793.1.patch, > Fix-TestFSErrorsExposed-2012-04-13_18_59_36.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252098#comment-13252098 ] Phabricator commented on HBASE-5763: amirshim has accepted the revision "[jira] [HBASE-5763] [89-fb] Fix random failures in TestFSErrorsExposed". Looks good REVISION DETAIL https://reviews.facebook.net/D2739 BRANCH fix_random_failures_in_HBASE-5763_v5 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251897#comment-13251897 ] Phabricator commented on HBASE-5763: stack has commented on the revision "[jira] [HBASE-5763] [89-fb] Fix random failures in TestFSErrorsExposed". lgtm REVISION DETAIL https://reviews.facebook.net/D2739 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch, D2739.3.patch, > D2739.4.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5763) Fix random failures in TestFSErrorsExposed
[ https://issues.apache.org/jira/browse/HBASE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251350#comment-13251350 ] Phabricator commented on HBASE-5763: stack has commented on the revision "[jira] [HBASE-5763] [89-fb] Fix random failures in TestFSErrorsExposed". Patch looks good but for the comment below. INLINE COMMENTS src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java:204 Do we have to wait ten seconds like this? Can we not poll somewhere to figure them up? REVISION DETAIL https://reviews.facebook.net/D2739 > Fix random failures in TestFSErrorsExposed > -- > > Key: HBASE-5763 > URL: https://issues.apache.org/jira/browse/HBASE-5763 > Project: HBase > Issue Type: Bug >Reporter: Mikhail Bautin >Assignee: Mikhail Bautin >Priority: Minor > Attachments: D2739.1.patch, D2739.2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira