[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257008#comment-13257008 ] Hudson commented on HBASE-5792: --- Integrated in HBase-0.94 #129 (See [https://builds.apache.org/job/HBase-0.94/129/]) HBASE-5792 HLog Performance Evaluation Tool (Revision 1327668) Result = FAILURE larsh : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256982#comment-13256982 ] Hudson commented on HBASE-5792: --- Integrated in HBase-0.94-security #15 (See [https://builds.apache.org/job/HBase-0.94-security/15/]) HBASE-5792 HLog Performance Evaluation Tool (Revision 1327668) Result = SUCCESS larsh : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.94.0, 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255644#comment-13255644 ] stack commented on HBASE-5792: -- @Todd Thanks. I removed TestHLogBench over in HBASE-5808. The new test does verify and actually writes a log which TestHLogBench does not. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255342#comment-13255342 ] Hudson commented on HBASE-5792: --- Integrated in HBase-TRUNK-security #173 (See [https://builds.apache.org/job/HBase-TRUNK-security/173/]) HBASE-5792 HLog Performance Evaluation Tool (Revision 1326793) HBASE-5792 HLog Performance Evaluation Tool (Revision 1326792) Result = FAILURE stack : Files : * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255337#comment-13255337 ] Todd Lipcon commented on HBASE-5792: I just noticed we already have a "TestHLogBench" tool which appears pretty close to this... we should merge the two in some way or be clear on what the difference is. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255091#comment-13255091 ] Hudson commented on HBASE-5792: --- Integrated in HBase-TRUNK #2769 (See [https://builds.apache.org/job/HBase-TRUNK/2769/]) HBASE-5792 HLog Performance Evaluation Tool (Revision 1326793) HBASE-5792 HLog Performance Evaluation Tool (Revision 1326792) Result = SUCCESS stack : Files : * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Fix For: 0.96.0 > > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch, verify.txt, verify.txt > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254937#comment-13254937 ] Hadoop QA commented on HBASE-5792: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522825/HBASE-5792-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1539//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1539//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1539//console This message is automatically generated. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254869#comment-13254869 ] stack commented on HBASE-5792: -- @Matteo NVM. I want to use this tool now so I'll take care of the above. Good stuff. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch, > HBASE-5792-v2.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254827#comment-13254827 ] stack commented on HBASE-5792: -- This is great Matteo. We need this. Yeah, agree, this tool will have most value if it puts nothing but a lone region (and WAL). Few minors below: Missing annotatations on audience. Do you need these? IIRC, the default exists w/ need of definition: {code} + public HLogPerformanceEvaluation() { + } {code} You do it in another place at least too. No harm adding a bit of class doc on HLogPutBenchmark You don't want to use a command parser? > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254654#comment-13254654 ] Matteo Bertozzi commented on HBASE-5792: @Jonathan the previous version had a HBaseAdmin call at startup because the tool contains also a Put test, but the hbase up si not needed. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254650#comment-13254650 ] Jonathan Hsieh commented on HBASE-5792: --- When I ran a previous version of this I believe it wanted a hbase cluster up, we should make sure this works without that. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254496#comment-13254496 ] Todd Lipcon commented on HBASE-5792: bq. I wonder if it makes sense to persist benchmark results to HBase. Let's not scope creep. The point of this tool is to have a quick benchmark you can run without having to set up an HBase cluster. Outputting results on the console is good enough to parse and store in whatever database you want. My preference would probably be just appending to a text file for easy graphing from Hudson. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254436#comment-13254436 ] Zhihong Yu commented on HBASE-5792: --- I wonder if it makes sense to persist benchmark results to HBase. That may show us some trend w.r.t. HLog performance. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254428#comment-13254428 ] Matteo Bertozzi commented on HBASE-5792: Don't know if it makes sense catch the InterruptException, since we're trying to test write performance with nThreads... if we lost one thread, the test doesn't reflect what we've asked for. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254426#comment-13254426 ] Zhihong Yu commented on HBASE-5792: --- Minor comments: {code} import org.apache.hadoop.conf.Configuration; {code} The above import was not used. {code} for (Thread t : threads) t.join(); {code} join() may throw InterruptedException. Shall we catch it and proceed to the next Thread to be joined ? > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254393#comment-13254393 ] Hadoop QA commented on HBASE-5792: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522711/HBASE-5792-v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1532//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1532//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1532//console This message is automatically generated. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254371#comment-13254371 ] Zhihong Yu commented on HBASE-5792: --- Interesting tool. {code} +region = HRegion.createHRegion(regionInfo, regionRootDir, getConf(), htd); {code} I don't see where region is closed. There should be some cleanup method after the benchmarking is completed. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5792) HLog Performance Evaluation Tool
[ https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254156#comment-13254156 ] Hadoop QA commented on HBASE-5792: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522681/HBASE-5792-v0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1526//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1526//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1526//console This message is automatically generated. > HLog Performance Evaluation Tool > > > Key: HBASE-5792 > URL: https://issues.apache.org/jira/browse/HBASE-5792 > Project: HBase > Issue Type: Test > Components: wal >Reporter: Matteo Bertozzi >Assignee: Matteo Bertozzi >Priority: Minor > Labels: performance, wal > Attachments: HBASE-5792-v0.patch > > > Related to HDFS-3280 and the HBase WAL slowdown on 0.23+ > It would be nice to have a simple tool like HFilePerformanceEvaluation, ... > to be able to check easily the HLog performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira