[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260263#comment-13260263 ] Hudson commented on HBASE-5830: --- Integrated in HBase-TRUNK-security #182 (See [https://builds.apache.org/job/HBase-TRUNK-security/182/]) HBASE-5830 Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. (Revision 1329443) Result = SUCCESS stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 0.96.0 > > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260047#comment-13260047 ] Hudson commented on HBASE-5830: --- Integrated in HBase-TRUNK #2801 (See [https://builds.apache.org/job/HBase-TRUNK/2801/]) HBASE-5830 Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk. (Revision 1329443) Result = FAILURE stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 0.96.0 > > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[
https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259855#comment-13259855
]
Uma Maheswara Rao G commented on HBASE-5830:
{quote} -1 tests included. The patch doesn't appear to include any new or
modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{quote}
No tests included , as this is the patch to use the SequenceFile#Writer API
directly, instead of using reflections.
Thanks a lot, Stack for the review!
> Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer
> directly in trunk.
> ---
>
> Key: HBASE-5830
> URL: https://issues.apache.org/jira/browse/HBASE-5830
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 0.96.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5830.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259830#comment-13259830 ] Hadoop QA commented on HBASE-5830: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523829/HBASE-5830.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1611//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1611//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1611//console This message is automatically generated. > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259802#comment-13259802 ] stack commented on HBASE-5830: -- +1 on patch then. > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[
https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259800#comment-13259800
]
Uma Maheswara Rao G commented on HBASE-5830:
Yes, both has the public api:
Hadoop-2 or trunk code:
SequenceFile#Writer:
{code}
/** flush all currently written data to the file system */
public void syncFs() throws IOException {
if (out != null) {
out.hflush(); // flush contents to file system
}
}
{code}
Branch-1:
SequenceFile#Writer:
{code}
/** flush all currently written data to the file system */
public void syncFs() throws IOException {
if (out != null) {
out.sync(); // flush contents to file
system
}
}
{code}
> Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer
> directly in trunk.
> ---
>
> Key: HBASE-5830
> URL: https://issues.apache.org/jira/browse/HBASE-5830
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 0.96.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5830.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259784#comment-13259784 ] stack commented on HBASE-5830: -- This will work for hadoop 1.0.x and for hadoop 2.x Uma? > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5830) Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer directly in trunk.
[ https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259767#comment-13259767 ] Uma Maheswara Rao G commented on HBASE-5830: Attached the patch. SequenceFileLogWriter will use the syncFs api from SequenceFile writer. > Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer > directly in trunk. > --- > > Key: HBASE-5830 > URL: https://issues.apache.org/jira/browse/HBASE-5830 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 0.96.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HBASE-5830.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
