[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268544#comment-13268544 ] Phabricator commented on HBASE-5847: tedyu has accepted the revision [jira] [HBASE-5847] Support createTable(splitKeys) in Thrift. REVISION DETAIL https://reviews.facebook.net/D3039 BRANCH 5847 Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial Attachments: D3039.1.patch The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268548#comment-13268548 ] Hadoop QA commented on HBASE-5847: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525648/D3039.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1768//console This message is automatically generated. Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial Attachments: D3039.1.patch The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13268566#comment-13268566 ] Zhihong Yu commented on HBASE-5847: --- Looks like src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java needs to be generated again. Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial Attachments: D3039.1.patch The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266108#comment-13266108 ] stack commented on HBASE-5847: -- @Nicolas Up to you. Not necessary. Just thought if it was there already, you could take it from thrift2. One day we'll have to reconcile the two and go for one or the other. Until then, they will both get the fly-by-treatment w/ fellas adding what they need just now. Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13263756#comment-13263756 ] Nicolas Spiegelberg commented on HBASE-5847: @stack: I assume you're talking about HBASE-1744? thrift2 does not have this API either. I take it I should put the new API in thrift/Hbase.thrift? Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5847) Support createTable(splitKeys) in Thrift
[ https://issues.apache.org/jira/browse/HBASE-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13260270#comment-13260270 ] stack commented on HBASE-5847: -- Does the thrift2 package support this Nicolas? Support createTable(splitKeys) in Thrift Key: HBASE-5847 URL: https://issues.apache.org/jira/browse/HBASE-5847 Project: HBase Issue Type: Improvement Reporter: Nicolas Spiegelberg Assignee: Nicolas Spiegelberg Priority: Trivial The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
