[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289038#comment-13289038 ] Hudson commented on HBASE-5892: --- Integrated in HBase-0.94-security #34 (See [https://builds.apache.org/job/HBase-0.94-security/34/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345889) Result = SUCCESS jmhsieh : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288852#comment-13288852 ] Hudson commented on HBASE-5892: --- Integrated in HBase-0.92-security #110 (See [https://builds.apache.org/job/HBase-0.92-security/110/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345888) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288519#comment-13288519 ] Hudson commented on HBASE-5892: --- Integrated in HBase-0.92 #443 (See [https://builds.apache.org/job/HBase-0.92/443/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345888) Result = FAILURE jmhsieh : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288498#comment-13288498 ] Hudson commented on HBASE-5892: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #39 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/39/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345890) Result = FAILURE jmhsieh : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288489#comment-13288489 ] Hudson commented on HBASE-5892: --- Integrated in HBase-0.94 #244 (See [https://builds.apache.org/job/HBase-0.94/244/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345889) Result = SUCCESS jmhsieh : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288485#comment-13288485 ] Hudson commented on HBASE-5892: --- Integrated in HBase-TRUNK #2982 (See [https://builds.apache.org/job/HBase-TRUNK/2982/]) HBASE-5892 [hbck] Refactor parallel WorkItem* to Futures (Andrew Wang) (Revision 1345890) Result = FAILURE jmhsieh : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement > Components: hbck >Affects Versions: 0.90.6, 0.92.1, 0.94.0 >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Fix For: 0.90.7, 0.96.0, 0.94.1, 0.92.3 > > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288418#comment-13288418 ] Jonathan Hsieh commented on HBASE-5892: --- Looks good to me. I was able to apply the v4 version to trunk and to 0.92/0.94 via 'patch -p1 < hbase-5892-4.patch' but at the moment am having problems with my account. Will commit when I get fixed. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288334#comment-13288334 ] Anoop Sam John commented on HBASE-5892: --- @Andrew The issue with findbugs is solved as part of HBASE-6138 > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[
https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287748#comment-13287748
]
Andrew Wang commented on HBASE-5892:
I don't know why Findbugs is erroring. Maybe the modularization change?
{code}
[ERROR] Could not find resource
'${parent.basedir}/dev-support/findbugs-exclude.xml'. -> [Help 1]
{code}
No tests because there's no functionality change, it's a refactor.
> [hbck] Refactor parallel WorkItem* to Futures.
> --
>
> Key: HBASE-5892
> URL: https://issues.apache.org/jira/browse/HBASE-5892
> Project: HBase
> Issue Type: Improvement
>Reporter: Jonathan Hsieh
>Assignee: Andrew Wang
> Labels: noob
> Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch,
> hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch,
> hbase-5892-4.patch, hbase-5892.patch
>
>
> This would convert WorkItem* logic (with low level notifies, and rough
> exception handling) into a more canonical Futures pattern.
> Currently there are two instances of this pattern (for loading hdfs dirs, for
> contacting regionservers for assignments, and soon -- for loading hdfs
> .regioninfo files).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285983#comment-13285983 ] Hadoop QA commented on HBASE-5892: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530256/hbase-5892-4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2059//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2059//console This message is automatically generated. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285955#comment-13285955 ] Hadoop QA commented on HBASE-5892: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530243/hbase-5892-3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint org.apache.hadoop.hbase.master.TestAssignmentManager org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2058//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2058//console This message is automatically generated. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285927#comment-13285927 ] Andrew Wang commented on HBASE-5892: Okay, respun both versions to fix the code style comments. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892-4-0.90.patch, > hbase-5892-4.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[
https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285864#comment-13285864
]
Zhihong Yu commented on HBASE-5892:
---
Minor comment:
{code}
+List work = new
ArrayList(regionServerList.size());
{code}
variable work should be named works.
{code}
+if(hdfsEntry.hri != null) {
{code}
Insert space between if and (.
> [hbck] Refactor parallel WorkItem* to Futures.
> --
>
> Key: HBASE-5892
> URL: https://issues.apache.org/jira/browse/HBASE-5892
> Project: HBase
> Issue Type: Improvement
>Reporter: Jonathan Hsieh
>Assignee: Andrew Wang
> Labels: noob
> Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch,
> hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892.patch
>
>
> This would convert WorkItem* logic (with low level notifies, and rough
> exception handling) into a more canonical Futures pattern.
> Currently there are two instances of this pattern (for loading hdfs dirs, for
> contacting regionservers for assignments, and soon -- for loading hdfs
> .regioninfo files).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285854#comment-13285854 ] Andrew Wang commented on HBASE-5892: Re-diffed to get the right prefix. Thanks Zhihong. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892-3.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285349#comment-13285349 ] Zhihong Yu commented on HBASE-5892: --- @Andrew: The path for source file should have hbase-server/ prefix. This is due to modularization change. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285306#comment-13285306 ] Hadoop QA commented on HBASE-5892: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530128/hbase-5892-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2042//console This message is automatically generated. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285303#comment-13285303 ] Zhihong Yu commented on HBASE-5892: --- The practice is to attach trunk patch separately after attaching the other patches. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285301#comment-13285301 ] Andrew Wang commented on HBASE-5892: Patch failed to apply because Jenkins tried to apply the version I made for 0.90 to trunk. I don't know how to kick the build bot to make it do the right thing for different versions... > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283764#comment-13283764 ] Hadoop QA commented on HBASE-5892: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12529803/hbase-5892-2-0.90.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2003//console This message is automatically generated. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283759#comment-13283759 ] Andrew Wang commented on HBASE-5892: Another rev, tried to fix the one relevant FindBugs error I saw. The patch for trunk applied cleanly to 0.94 and 0.92; provided is the slightly modified patch for 0.90. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892-2-0.90.patch, > hbase-5892-2.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283741#comment-13283741 ] Hadoop QA commented on HBASE-5892: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12529780/hbase-5892-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2001//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2001//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2001//console This message is automatically generated. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283714#comment-13283714 ] Andrew Wang commented on HBASE-5892: Ran TestHBaseFsck, had to fix a null pointer thus new version of the patch. I'll port it to prior versions too. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892-1.patch, hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283369#comment-13283369 ] Jonathan Hsieh commented on HBASE-5892: --- Andrew, looks good. I'm going to wait for the hadoopqa robot to execute the test suite. Alternately, since this just modifies hbck, can you try this command and share results: 'mvn test -PlocalTests -Dtest=TestHbaseFsck'? I'd like to keep all hbck across versions essentially the same -- would you be willing to port to 0.90/0.92/0.94? I'd bet that this may apply to 0.94 and 0.92, and that 0.90 would require some near trivial tweaks. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh >Assignee: Andrew Wang > Labels: noob > Attachments: hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5892) [hbck] Refactor parallel WorkItem* to Futures.
[ https://issues.apache.org/jira/browse/HBASE-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282790#comment-13282790 ] Andrew Wang commented on HBASE-5892: I tried to do this refactor, essentially switching out Runnable for Callable and adding some more logging in the process. Let me know if it's not what you were thinking of. I didn't do any testing beyond running hbck on my local machine, which seemed to work. > [hbck] Refactor parallel WorkItem* to Futures. > -- > > Key: HBASE-5892 > URL: https://issues.apache.org/jira/browse/HBASE-5892 > Project: HBase > Issue Type: Improvement >Reporter: Jonathan Hsieh > Labels: noob > Attachments: hbase-5892.patch > > > This would convert WorkItem* logic (with low level notifies, and rough > exception handling) into a more canonical Futures pattern. > Currently there are two instances of this pattern (for loading hdfs dirs, for > contacting regionservers for assignments, and soon -- for loading hdfs > .regioninfo files). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
