[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294841#comment-13294841
]
Ted Yu commented on HBASE-5924:
---
Strange that TestDrainingServer failed Hadoop QA.
It passed
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294928#comment-13294928
]
Hudson commented on HBASE-5924:
---
Integrated in HBase-TRUNK #3023 (See
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294977#comment-13294977
]
Hudson commented on HBASE-5924:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #53 (See
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295204#comment-13295204
]
stack commented on HBASE-5924:
--
I took a look at committed patch. This looks great.
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294587#comment-13294587
]
nkeywal commented on HBASE-5924:
v19 with all the comments taken into account. I will
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294612#comment-13294612
]
Hadoop QA commented on HBASE-5924:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293775#comment-13293775
]
nkeywal commented on HBASE-5924:
@ted: Ok. These issues were already in my initial patch.
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13293778#comment-13293778
]
Zhihong Ted Yu commented on HBASE-5924:
---
I don't have further comments.
Thanks
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291624#comment-13291624
]
nkeywal commented on HBASE-5924:
I've done some changes to
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291644#comment-13291644
]
Hadoop QA commented on HBASE-5924:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291656#comment-13291656
]
nkeywal commented on HBASE-5924:
I don't reproduce locally the issue on
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291657#comment-13291657
]
Zhihong Ted Yu commented on HBASE-5924:
---
With RSTracker gone, the following flag is
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291663#comment-13291663
]
nkeywal commented on HBASE-5924:
bq. With RSTracker gone, the following flag is no longer
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291811#comment-13291811
]
Zhihong Ted Yu commented on HBASE-5924:
---
{code}
$ find hbase-server/src/test -name
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291815#comment-13291815
]
nkeywal commented on HBASE-5924:
bq. w.r.t. table.close(), it is good programming practice
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291889#comment-13291889
]
Zhihong Ted Yu commented on HBASE-5924:
---
{code}
+if (loc == null)
+
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290899#comment-13290899
]
nkeywal commented on HBASE-5924:
@ted
bq. 'origin' - 'original', 'what are the actions to
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291069#comment-13291069
]
stack commented on HBASE-5924:
--
Upload v10 nkeywal and we'll commit it. Thanks for responses
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291370#comment-13291370
]
nkeywal commented on HBASE-5924:
v11: I changed the names to match HTableInterface#batch,
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291375#comment-13291375
]
nkeywal commented on HBASE-5924:
Ok, I got a random failure in a test I touched
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291434#comment-13291434
]
Hadoop QA commented on HBASE-5924:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291476#comment-13291476
]
Zhihong Ted Yu commented on HBASE-5924:
---
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290339#comment-13290339
]
nkeywal commented on HBASE-5924:
v9, with:
- Ted's comment taken into account
- Full
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290443#comment-13290443
]
stack commented on HBASE-5924:
--
@nkeywal Did you add the history in the first place? Why is
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290483#comment-13290483
]
Zhihong Ted Yu commented on HBASE-5924:
---
{code}
+ // We need the origin
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13290509#comment-13290509
]
Zhihong Ted Yu commented on HBASE-5924:
---
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13289591#comment-13289591
]
nkeywal commented on HBASE-5924:
Bumped the priority to major to make clear it's a
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13289646#comment-13289646
]
Hadoop QA commented on HBASE-5924:
--
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13289703#comment-13289703
]
Zhihong Ted Yu commented on HBASE-5924:
---
Nice work.
{code}
private static class
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287582#comment-13287582
]
nkeywal commented on HBASE-5924:
This leads to a complete rewriting of the
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287595#comment-13287595
]
Zhihong Yu commented on HBASE-5924:
---
For #2 above, I think we can remove the callback in
[
https://issues.apache.org/jira/browse/HBASE-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267934#comment-13267934
]
stack commented on HBASE-5924:
--
+1
In the client code, don't wait for all
32 matches
Mail list logo