[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-11-29 Thread Jean-Daniel Cryans (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506801#comment-13506801 ] Jean-Daniel Cryans commented on HBASE-5926: --- This jira has the odd side-effect

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278654#comment-13278654 ] nkeywal commented on HBASE-5926: v13 should do it... Delete the master

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278682#comment-13278682 ] Hadoop QA commented on HBASE-5926: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278919#comment-13278919 ] nkeywal commented on HBASE-5926: I think it's ok, I don't have this locally...

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278967#comment-13278967 ] Zhihong Yu commented on HBASE-5926: --- Minor comments: {code} + * servers. It allows to

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279000#comment-13279000 ] stack commented on HBASE-5926: -- +1 on patch v14 Delete the master znode

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279005#comment-13279005 ] stack commented on HBASE-5926: -- I'll fix Ted comments on commit. Delete the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279031#comment-13279031 ] Hudson commented on HBASE-5926: --- Integrated in HBase-TRUNK #2899 (See

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279042#comment-13279042 ] Hadoop QA commented on HBASE-5926: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279040#comment-13279040 ] Zhihong Yu commented on HBASE-5926: --- ZNodeClearer.java isn't in source repo.

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279048#comment-13279048 ] stack commented on HBASE-5926: -- Fixed. Thanks Ted. Delete the master znode

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279122#comment-13279122 ] Hudson commented on HBASE-5926: --- Integrated in HBase-TRUNK #2900 (See

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279333#comment-13279333 ] Hudson commented on HBASE-5926: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #10 (See

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277684#comment-13277684 ] nkeywal commented on HBASE-5926: v8. with Ted's comments taken into account.

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277696#comment-13277696 ] Hadoop QA commented on HBASE-5926: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277702#comment-13277702 ] nkeywal commented on HBASE-5926: These tests run ok locally. Delete the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277971#comment-13277971 ] Zhihong Yu commented on HBASE-5926: --- Please add javadoc for the new class: {code}

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277996#comment-13277996 ] nkeywal commented on HBASE-5926: bq. javadoc done. bq. readMyEphemeralNodeOnDisk() throws

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277997#comment-13277997 ] Zhihong Yu commented on HBASE-5926: --- bq. I now clone the conf. That is safer, avoiding

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278052#comment-13278052 ] Hadoop QA commented on HBASE-5926: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278065#comment-13278065 ] Zhihong Yu commented on HBASE-5926: --- @Stack: Can you comment on the latest patch ?

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278078#comment-13278078 ] stack commented on HBASE-5926: -- CleanZNode should be in the tool package or in zookeeper

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278147#comment-13278147 ] nkeywal commented on HBASE-5926: bq. You should look at the javadoc that is created from

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278180#comment-13278180 ] stack commented on HBASE-5926: -- bq. We need the content. For the regionserver, the content is

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278259#comment-13278259 ] nkeywal commented on HBASE-5926: Yes, it could be the node name only. Does it make a

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278305#comment-13278305 ] Zhihong Yu commented on HBASE-5926: --- @N: Did you forget to include ZNodeClearer class in

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278312#comment-13278312 ] Zhihong Yu commented on HBASE-5926: --- {code} +} catch (KeeperException e) { +

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278342#comment-13278342 ] stack commented on HBASE-5926: -- Its fine putting it in file. And what Ted said. Thanks N.

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-16 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277172#comment-13277172 ] nkeywal commented on HBASE-5926: the race condition is decreased to a

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-16 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277180#comment-13277180 ] Zhihong Yu commented on HBASE-5926: --- I cannot find CleanZnode class in the patch.

[jira] [Commented] (HBASE-5926) Delete the master znode after a master crash

2012-05-16 Thread Zhihong Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277190#comment-13277190 ] Zhihong Yu commented on HBASE-5926: --- {code} +Usage: Master [opts]