[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285223#comment-13285223 ] Hudson commented on HBASE-6084: --- Integrated in HBase-TRUNK #2946 (See [https://builds.apache.org/job/HBase-TRUNK/2946/]) HBASE-6084 Server Load does not display correctly on the ui (Revision 1344023) Result = SUCCESS stack : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-6084-0.patch, HBASE-6084-1.patch, HBASE-6084-2.patch, HBASE-6084-3.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285273#comment-13285273 ] Hudson commented on HBASE-6084: --- Integrated in HBase-TRUNK #2947 (See [https://builds.apache.org/job/HBase-TRUNK/2947/]) HBASE-6084 Server Load does not display correctly on the ui (Revision 1344026) Result = FAILURE stack : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-6084-0.patch, HBASE-6084-1.patch, HBASE-6084-2.patch, HBASE-6084-3.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285283#comment-13285283 ] Hudson commented on HBASE-6084: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #31 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/31/]) HBASE-6084 Server Load does not display correctly on the ui (Revision 1344026) HBASE-6084 Server Load does not display correctly on the ui (Revision 1344023) Result = FAILURE stack : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java stack : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-6084-0.patch, HBASE-6084-1.patch, HBASE-6084-2.patch, HBASE-6084-3.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282780#comment-13282780 ] Elliott Clark commented on HBASE-6084: -- So the errors on console are pretty un-related. so I filed HBASE-6090. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282784#comment-13282784 ] Gregory Chanan commented on HBASE-6084: --- The JMX issues are tracked in HBASE-5967. Is this a duplicate? Or are you only talking about fixing toString here and the JMX issues are separate? I like your idea about copying the format of the old one. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282802#comment-13282802 ] Elliott Clark commented on HBASE-6084: -- This was only for the UI which required to string. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[
https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282812#comment-13282812
]
Gregory Chanan commented on HBASE-6084:
---
Elliot,
I'm a bit confused. When I look at 0.92.1's HServerLoad.toString I see:
{code}
int numberOfRegions = this.regionLoad.size();
StringBuilder sb = new StringBuilder();
sb = Strings.appendKeyValue(sb, requestsPerSecond,
Integer.valueOf(numberOfRequests/msgInterval));
sb = Strings.appendKeyValue(sb, numberOfOnlineRegions,
Integer.valueOf(numberOfRegions));
sb = Strings.appendKeyValue(sb, usedHeapMB,
Integer.valueOf(this.usedHeapMB));
sb = Strings.appendKeyValue(sb, maxHeapMB, Integer.valueOf(maxHeapMB));
return sb.toString();
{code}
But your toString doesn't match. It looks like you implemented
HServerLoad.RegionLoad's toString in ServerLoad?
Server Load does not display correctly on the ui
Key: HBASE-6084
URL: https://issues.apache.org/jira/browse/HBASE-6084
Project: HBase
Issue Type: Bug
Reporter: Elliott Clark
Assignee: Elliott Clark
Attachments: HBASE-6084-0.patch, HBASE-6084-1.patch
The ui uses the toString method and toString does not implement it any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282814#comment-13282814 ] Gregory Chanan commented on HBASE-6084: --- I think what we need to do is the following: 1) Write a ServerLoad.toString that matches HServerLoad.toString. 2) Implement a RegionLoad (not HServerLoad.RegionLoad) that wraps the protobuf RegionLoad, like how ServerLoad wraps the protobuf ServerLoad 3) Write a RegionLoad.toString that matches HServerLoad.RegionLoad.toString Does that seem correct to you or am I missing something? You should be able to do #1 now. I'm almost done with #2. you can track it in HBASE-5933. After #2, you should be able to do #3. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch, HBASE-6084-1.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282073#comment-13282073 ] Jonathan Hsieh commented on HBASE-6084: --- silly question -- why was it removed previously? Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282116#comment-13282116 ] Hadoop QA commented on HBASE-6084: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528832/HBASE-6084-0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1977//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1977//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1977//console This message is automatically generated. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282147#comment-13282147 ] Elliott Clark commented on HBASE-6084: -- Seems like the file was added when switching to protobuff and it never had a to string unlike HServerLoad. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282148#comment-13282148 ] Elliott Clark commented on HBASE-6084: -- In fact on looking at it a little more we should copy the format that the old one had just incase someone had a script screen scraping the master ui web page. I'll get that patch up in a little bit. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282154#comment-13282154 ] Todd Lipcon commented on HBASE-6084: I didn't file a JIRA yet but I also saw errors on my console about the JMX bean, where we return ServerLoad instances and JMX has no idea what to do with them. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6084) Server Load does not display correctly on the ui
[ https://issues.apache.org/jira/browse/HBASE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13282157#comment-13282157 ] Elliott Clark commented on HBASE-6084: -- Yeah, I've seen the same. I'll get get a MBean interface to get that fixed. Server Load does not display correctly on the ui Key: HBASE-6084 URL: https://issues.apache.org/jira/browse/HBASE-6084 Project: HBase Issue Type: Bug Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6084-0.patch The ui uses the toString method and toString does not implement it any more. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
