[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528273#comment-13528273 ] Jeffrey Zhong commented on HBASE-6367: -- Thanks for all the comments. I moved the backup master section right after region server list. -Jeffrey List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528287#comment-13528287 ] Elliott Clark commented on HBASE-6367: -- +1 List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[
https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528332#comment-13528332
]
Hadoop QA commented on HBASE-6367:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12560278/hbase-6367.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
101 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 23 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3479//console
This message is automatically generated.
List backup masters in ui.
--
Key: HBASE-6367
URL: https://issues.apache.org/jira/browse/HBASE-6367
Project: HBase
Issue Type: Improvement
Reporter: Elliott Clark
Assignee: Jeffrey Zhong
Priority: Minor
Labels: noob
Fix For: 0.96.0
Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png,
hbase-6367.patch, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png
Right now only the active master shows any information on the web ui. It
would be nice to see that there are backup masters waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528361#comment-13528361 ] Hudson commented on HBASE-6367: --- Integrated in HBase-TRUNK #3606 (See [https://builds.apache.org/job/HBase-TRUNK/3606/]) HBASE-6367 List backup masters in ui. (Revision 1419787) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterListTmpl.jamon * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528411#comment-13528411 ] Jeffrey Zhong commented on HBASE-6367: -- The failed test case is org.apache.hadoop.hbase.util.TestThreads in HBase-Common. I rerun the case several times locally and all passed. In addition, the changes I made are unrelated to the failure case. List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528422#comment-13528422 ] Elliott Clark commented on HBASE-6367: -- Yep everything looks good thanks for the patch [~jeffreyz] List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528480#comment-13528480 ] Hudson commented on HBASE-6367: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #291 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/291/]) HBASE-6367 List backup masters in ui. (Revision 1419787) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterListTmpl.jamon * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, Has BackupMasters Ver 2.png, hbase-6367.patch, hbase-6367.patch, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508580#comment-13508580 ] Enis Soztutar commented on HBASE-6367: -- bq. Leaving the backup master header even though there is no backup masters is more clear to users espeically when a user migrates to new hbase version from an old one +1. There might be cases where the backup master is dead, but the user was expecting it. Showing the section with total 0 can be useful. List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508964#comment-13508964 ] Elliott Clark commented on HBASE-6367: -- bq. I can move the backup master section under region servers. Where do you think it's more appropriate(at the very bottom)? Either at the very bottom or after region servers list. My vote would be after the region server's list. My thinking is this. Most people will be combing to this page in order to see how their cluster is doing. This data is best represented by the regionservers list. Thoughts ? bq.There might be cases where the backup master is dead, but the user was expecting it. That's fair. My thought was just that users might be confused by empty headers' for things that are optional. All users need region servers but not all users will have a backup master. But discoverability could win out. List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507842#comment-13507842 ] Elliott Clark commented on HBASE-6367: -- Thanks for the patch. I think the placement's a little wrong. Backup masters should be below the region servers. Also if there are no backup servers we probably wouldn't want to put up the header. List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507897#comment-13507897 ] Jeffrey Zhong commented on HBASE-6367: -- Hey Elliott, I can move the backup master section under region servers. Where do you think it's more appropriate(at the very bottom)? For the header hiding, I saw current region server section still keep the header even though there is no region servers. Leaving the backup master header even though there is no backup masters is more clear to users espeically when a user migrates to new hbase version from an old one. Thanks, -Jeffrey List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Assignee: Jeffrey Zhong Priority: Minor Labels: noob Fix For: 0.96.0 Attachments: Has BackupMasters.png, hbase-6367.patch, No BackupMasters.png Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6367) List backup masters in ui.
[ https://issues.apache.org/jira/browse/HBASE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506940#comment-13506940 ] Jeffrey Zhong commented on HBASE-6367: -- Starting to work on this one. List backup masters in ui. -- Key: HBASE-6367 URL: https://issues.apache.org/jira/browse/HBASE-6367 Project: HBase Issue Type: Improvement Reporter: Elliott Clark Priority: Minor Labels: noob Right now only the active master shows any information on the web ui. It would be nice to see that there are backup masters waiting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
