[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465103#comment-13465103 ] Phabricator commented on HBASE-6882: mbautin has closed the revision [jira] [HBASE-6882] [89-fb] Thrift IOError should include exception class. CHANGED PRIOR TO COMMIT https://reviews.facebook.net/D5679?vs=18669id=18843#differential-review-toc REVISION DETAIL https://reviews.facebook.net/D5679 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1391221 To: Liyin, Karthik, aaiyer, chip, JIRA, mbautin Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463218#comment-13463218 ] Mikhail Bautin commented on HBASE-6882: --- Phabricator diff for 0.89-fb: https://reviews.facebook.net/D5679 Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463294#comment-13463294 ] Phabricator commented on HBASE-6882: Liyin has accepted the revision [jira] [HBASE-6882] [89-fb] Thrift IOError should include exception class. LGTM ! REVISION DETAIL https://reviews.facebook.net/D5679 BRANCH ioerror_class_name To: Liyin, Karthik, aaiyer, chip, JIRA, mbautin Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[
https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463503#comment-13463503
]
liang xie commented on HBASE-6882:
--
Hi Mikhail, seems attached file is not for current community TRUNK version?
since i saw :
{code:title=Hbase.thrift|borderStyle=solid}
exception IOError {
1: string message,
- 2: i64 backoffTimeMillis
+ 2: i64 backoffTimeMillis,
+ 3: string exceptionClass
}
{code}
there is no backoffTimeMillis parameter in struct IOError on current trunk code
and another thing, do we encourage using thrift2 more than thrift right now ?
if that's right, maybe changing thrift2's TIOError is great ?
Thrift IOError should include exception class
-
Key: HBASE-6882
URL: https://issues.apache.org/jira/browse/HBASE-6882
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D5679.1.patch
Return exception class as part of IOError thrown from the Thrift proxy or the
embedded Thrift server in the regionserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[
https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463504#comment-13463504
]
liang xie commented on HBASE-6882:
--
Hi Mikhail, seems attached file is not for current community TRUNK version?
since i saw :
{code:title=Hbase.thrift|borderStyle=solid}
exception IOError {
1: string message,
- 2: i64 backoffTimeMillis
+ 2: i64 backoffTimeMillis,
+ 3: string exceptionClass
}
{code}
there is no backoffTimeMillis parameter in struct IOError on current trunk code
and another thing, do we encourage using thrift2 more than thrift right now ?
if that's right, maybe changing thrift2's TIOError is great ?
Thrift IOError should include exception class
-
Key: HBASE-6882
URL: https://issues.apache.org/jira/browse/HBASE-6882
Project: HBase
Issue Type: Improvement
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Attachments: D5679.1.patch
Return exception class as part of IOError thrown from the Thrift proxy or the
embedded Thrift server in the regionserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463507#comment-13463507 ] stack commented on HBASE-6882: -- @Lang thrift2 tries to make the thrift apis more align w/ current trunk. thrift1 has most usage and hence more trust. What is lacking is an owner for either package. Without this folks show up and fix their particular issue in whatever package they are using and then move on. Would be grand if someone could drive thrift2 so it had all of thrift1 and was better aligned w/ the native apis. Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463511#comment-13463511 ] liang xie commented on HBASE-6882: -- Got it, [~saint@gmail.com] I'd like to have a try:) Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463514#comment-13463514 ] stack commented on HBASE-6882: -- @liang That'd be great. Would suggest first a survey of thrift1 and thrift2. Figure what the difference is. Do you want to have the two packages achieve parity? Or do you want to add what is in thrift2 to thrift1 and keep up thrift1? The exmamples package has stuff to exercise the thrift stuff. A few more unit tests would probably not go amiss. Good on you. Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463525#comment-13463525 ] stack commented on HBASE-6882: -- @Liang ... or just pick up any outstanding thrift issues and take a look at resolving them? Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6882) Thrift IOError should include exception class
[ https://issues.apache.org/jira/browse/HBASE-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13463532#comment-13463532 ] liang xie commented on HBASE-6882: -- Thanks [~saint@gmail.com] for nice guiding ! My plan is to resolve some outstanding thrift related issues firstly, afterwards i could know more details, then maybe i'll have a good feeling on how to fuse thriftthrift2. Don't worry, i'll send a design note before making any big change:) Thrift IOError should include exception class - Key: HBASE-6882 URL: https://issues.apache.org/jira/browse/HBASE-6882 Project: HBase Issue Type: Improvement Reporter: Mikhail Bautin Assignee: Mikhail Bautin Attachments: D5679.1.patch Return exception class as part of IOError thrown from the Thrift proxy or the embedded Thrift server in the regionserver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
