[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546757#comment-13546757 ] Hudson commented on HBASE-7508: --- Integrated in HBase-TRUNK #3709 (See

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546811#comment-13546811 ] Hudson commented on HBASE-7508: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #335 (See

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546121#comment-13546121 ] Jonathan Hsieh commented on HBASE-7508: --- Squish these into a single line? {code}

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546135#comment-13546135 ] stack commented on HBASE-7508: -- +1 Why does it want you not to assign null to local

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546175#comment-13546175 ] nkeywal commented on HBASE-7508: bq. Why does it want you not to assign null to local

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546194#comment-13546194 ] Jonathan Hsieh commented on HBASE-7508: --- I dislike this lawyerly stuff but it is

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546224#comment-13546224 ] Hadoop QA commented on HBASE-7508: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546227#comment-13546227 ] nkeywal commented on HBASE-7508: @[~jmhsieh] It seems it's available on a public repo

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546234#comment-13546234 ] stack commented on HBASE-7508: -- We can't ship LGPL. IMO, it should be fine having us depend

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546239#comment-13546239 ] nkeywal commented on HBASE-7508: It's suppose to be RetentionPolicy.CLASS. I.e. not needed

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546252#comment-13546252 ] Jonathan Hsieh commented on HBASE-7508: --- I'm fine with the non-lgpl library, or with

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546261#comment-13546261 ] Hadoop QA commented on HBASE-7508: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546268#comment-13546268 ] nkeywal commented on HBASE-7508: Let's go for the library way then. And ok for the doc

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread Jonathan Hsieh (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546272#comment-13546272 ] Jonathan Hsieh commented on HBASE-7508: --- +1 Fix simple findbugs

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546274#comment-13546274 ] stack commented on HBASE-7508: -- +1 You will open another issue to do the doc/lib?

[jira] [Commented] (HBASE-7508) Fix simple findbugs

2013-01-07 Thread nkeywal (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546277#comment-13546277 ] nkeywal commented on HBASE-7508: Done. Thanks for the review! Fix simple