[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580252#comment-13580252
]
Jean-Marc Spaggiari commented on HBASE-7728:
Has this been applied in 0.94?
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580254#comment-13580254
]
Harsh J commented on HBASE-7728:
Per
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580255#comment-13580255
]
Jean-Marc Spaggiari commented on HBASE-7728:
Yep, I just figured I looked at
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570985#comment-13570985
]
Hudson commented on HBASE-7728:
---
Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569989#comment-13569989
]
Anoop Sam John commented on HBASE-7728:
---
So in such a case we need to distinguish
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569544#comment-13569544
]
ramkrishna.s.vasudevan commented on HBASE-7728:
---
bq.For sync'ing you're
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569602#comment-13569602
]
Lars Hofhansl commented on HBASE-7728:
--
I think the reasoning would go like this:
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568580#comment-13568580
]
Anoop Sam John commented on HBASE-7728:
---
[~yuzhih...@gmail.com]
+this.writer
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568694#comment-13568694
]
Anoop Sam John commented on HBASE-7728:
---
[~stack] Checked with 2 threads and giving
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568813#comment-13568813
]
Lars Hofhansl commented on HBASE-7728:
--
Am still not 100% sold that we need to set
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568944#comment-13568944
]
ramkrishna.s.vasudevan commented on HBASE-7728:
---
Patch looks good. Nice
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568953#comment-13568953
]
Ted Yu commented on HBASE-7728:
---
The null check originated from the fact that Writer doesn't
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569046#comment-13569046
]
Lars Hofhansl commented on HBASE-7728:
--
The fact that the writer might be closed
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569065#comment-13569065
]
Ted Yu commented on HBASE-7728:
---
In the current formation:
{code}
tempWriter =
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569069#comment-13569069
]
Lars Hofhansl commented on HBASE-7728:
--
That is why we should not change that. What I
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569074#comment-13569074
]
Ted Yu commented on HBASE-7728:
---
I will trim down the 0.94 patch, attach it here and run
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569104#comment-13569104
]
Ted Yu commented on HBASE-7728:
---
Here're the 0.94 tests I ran with simplified patch:
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569105#comment-13569105
]
Ted Yu commented on HBASE-7728:
---
Integrated to 0.94 and trunk.
Thanks for the reviews,
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569179#comment-13569179
]
Lars Hofhansl commented on HBASE-7728:
--
Posthumous +1 :)
deadlock
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569200#comment-13569200
]
Hudson commented on HBASE-7728:
---
Integrated in HBase-0.94 #816 (See
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569272#comment-13569272
]
stack commented on HBASE-7728:
--
Looks like I just ran into this:
{code}
Java stack
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569279#comment-13569279
]
Sergey Shelukhin commented on HBASE-7728:
-
I have a meta question about retrying
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569314#comment-13569314
]
Hudson commented on HBASE-7728:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #389 (See
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569325#comment-13569325
]
Lars Hofhansl commented on HBASE-7728:
--
If the flush fails we'd flush these edit into
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567496#comment-13567496
]
Anoop Sam John commented on HBASE-7728:
---
LogRoller thread trying to do a rolling
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567519#comment-13567519
]
Anoop Sam John commented on HBASE-7728:
---
With out assuming the log roll in catch
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567546#comment-13567546
]
ramkrishna.s.vasudevan commented on HBASE-7728:
---
Yes logs will be needed.
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567550#comment-13567550
]
Anoop Sam John commented on HBASE-7728:
---
Yes Ram the locks are correctly used AFA I
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567553#comment-13567553
]
Anoop Sam John commented on HBASE-7728:
---
[~aaronwq] Any chance for logs?
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567551#comment-13567551
]
Anoop Sam John commented on HBASE-7728:
---
Sorry.. thread dump ;)
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567554#comment-13567554
]
ramkrishna.s.vasudevan commented on HBASE-7728:
---
I am checking with latest
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567570#comment-13567570
]
Anoop Sam John commented on HBASE-7728:
---
I can see getting an IOE wrapping a NPE
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568273#comment-13568273
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568321#comment-13568321
]
Lars Hofhansl commented on HBASE-7728:
--
How are we getting into HLog.syncer() with
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568324#comment-13568324
]
Lars Hofhansl commented on HBASE-7728:
--
Oh I see:
rollWriter - cleanupCurrentWriter -
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568352#comment-13568352
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568360#comment-13568360
]
Lars Hofhansl commented on HBASE-7728:
--
This was an 0.94 patch. Lemme make a trunk
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568409#comment-13568409
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568427#comment-13568427
]
Ted Yu commented on HBASE-7728:
---
TestLogRollingNoCluster, the test added for concurrent log
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568429#comment-13568429
]
Anoop Sam John commented on HBASE-7728:
---
Ted
synchronized (this.updateLock) {
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568439#comment-13568439
]
Lars Hofhansl commented on HBASE-7728:
--
Of course Ted. That's why I named it
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568452#comment-13568452
]
Lars Hofhansl commented on HBASE-7728:
--
Does it need the part where it sets the
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568453#comment-13568453
]
Anoop Sam John commented on HBASE-7728:
---
bq.Does it need the part where it sets the
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568464#comment-13568464
]
Lars Hofhansl commented on HBASE-7728:
--
Do not we not have to check for tempWriter ==
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568467#comment-13568467
]
Anoop Sam John commented on HBASE-7728:
---
bq.Do not we not have to check for
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568480#comment-13568480
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568485#comment-13568485
]
Ted Yu commented on HBASE-7728:
---
I ran the two tests locally with patch and they passed:
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568490#comment-13568490
]
Anoop Sam John commented on HBASE-7728:
---
[~yuzhih...@gmail.com] You mean this?
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568504#comment-13568504
]
Anoop Sam John commented on HBASE-7728:
---
Ted
In the last patch you removed the null
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568506#comment-13568506
]
Ted Yu commented on HBASE-7728:
---
TestLogRollingNoCluster and *HLog* tests passed for 0.94
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568507#comment-13568507
]
Ted Yu commented on HBASE-7728:
---
In both 0.94 and trunk, we have:
{code}
void
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568511#comment-13568511
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568520#comment-13568520
]
Hadoop QA commented on HBASE-7728:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568524#comment-13568524
]
stack commented on HBASE-7728:
--
How we know this fixes the deadlock? Can we manufacture it
54 matches
Mail list logo
