[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607233#comment-13607233 ] Hudson commented on HBASE-8135: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #455 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/455/]) HBASE-8135 Mutation should implement HeapSize (Revision 1458418) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607225#comment-13607225 ] Hudson commented on HBASE-8135: --- Integrated in hbase-0.95-on-hadoop2 #34 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/34/]) HBASE-8135 Mutation should implement HeapSize (Revision 1458421) Result = FAILURE nkeywal : Files : * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java * /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606828#comment-13606828 ] Hudson commented on HBASE-8135: --- Integrated in hbase-0.95 #87 (See [https://builds.apache.org/job/hbase-0.95/87/]) HBASE-8135 Mutation should implement HeapSize (Revision 1458421) Result = FAILURE nkeywal : Files : * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java * /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606729#comment-13606729 ] Hudson commented on HBASE-8135: --- Integrated in HBase-TRUNK #3973 (See [https://builds.apache.org/job/HBase-TRUNK/3973/]) HBASE-8135 Mutation should implement HeapSize (Revision 1458418) Result = SUCCESS nkeywal : Files : * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHeapSize.java > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606568#comment-13606568 ] nkeywal commented on HBASE-8135: This seems to prove that we're in the usual flakiness (thanks for having relaunched the tests, Ted). Committed to trunk and 0.95. Thanks for the review, Stack & Ted! > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606441#comment-13606441
]
Hadoop QA commented on HBASE-8135:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574350/8135.v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4889//console
This message is automatically generated.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt,
> 8135.v4.patch, 8135.v5.patch, 8135.v5.patch, 8135.v5.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606244#comment-13606244
]
Hadoop QA commented on HBASE-8135:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574335/8135.v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestJoinedScanners
org.apache.hadoop.hbase.client.TestHTableMultiplexer
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4888//console
This message is automatically generated.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt,
> 8135.v4.patch, 8135.v5.patch, 8135.v5.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606203#comment-13606203
]
Hadoop QA commented on HBASE-8135:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574332/8135.v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestJoinedScanners
org.apache.hadoop.hbase.client.TestHTableMultiplexer
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4886//console
This message is automatically generated.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt,
> 8135.v4.patch, 8135.v5.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606196#comment-13606196 ] nkeywal commented on HBASE-8135: v5 is what I will commit if the build runs ok. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, > 8135.v4.patch, 8135.v5.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606188#comment-13606188 ] nkeywal commented on HBASE-8135: bq. There was a javadoc warning. Right. I'm going to hunt it. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, 8135.v4.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606186#comment-13606186 ] Ted Yu commented on HBASE-8135: --- There was a javadoc warning. Please fix. Other than that, +1. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, 8135.v4.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606183#comment-13606183 ] nkeywal commented on HBASE-8135: Thanks a lot Ted. For v4 I've just moved the test 'Put' with the other tests. I will commit as soon as I get a +1. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt, 8135.v4.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605793#comment-13605793
]
Hadoop QA commented on HBASE-8135:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574238/8135-v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4875//console
This message is automatically generated.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch, 8135.v2.patch, 8135-v3.txt
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605483#comment-13605483 ] nkeywal commented on HBASE-8135: Yes, just locally (I do test before submitting :-) ) I used ClassSize.align for timerange, and it went ok. But for Put/Delete/Increment, There are 88 bytes of difference I cannot explain. The code is on the v2.patch. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605475#comment-13605475 ] stack commented on HBASE-8135: -- Oh, this is just locally, no jenkins involved? You using ClassSize.align? > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605471#comment-13605471 ] stack commented on HBASE-8135: -- Try using -d32 flag locally. Jenkins seems to do 32bit java. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605470#comment-13605470 ] nkeywal commented on HBASE-8135: There is an issue: with the unit tests, I've got a huge gap I do not explain: Expected :80 Actual :168 2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 0 row class [B 2013-03-18 19:54:28,845 DEBUG [main] util.ClassSize(246): 1 ts long 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 2 writeToWAL boolean 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 3 familyMap interface java.util.NavigableMap 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(246): 4 attributes interface java.util.Map 2013-03-18 19:54:28,846 DEBUG [main] util.ClassSize(273): Primitives=9, arrays=1, references(includes 2 for object overhead)=5, refSize 8, size=80, prealign_size=73 Any hint? > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch, 8135.v2.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605362#comment-13605362
]
nkeywal commented on HBASE-8135:
I was trying to find a generic way to get the size of an object. A google
search on this leads to quite a lot of terrible practises :-). It should be
possible to do a static{} block for the fixed fields, but it won't bring much
actual value. With the current implementation, it's better to have unit tests
when ones adds fields. I'm going to do this in this patch (including Increment)
it will be simpler.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605341#comment-13605341 ] stack commented on HBASE-8135: -- [~ted_yu] Not in this patch. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605253#comment-13605253 ] Ted Yu commented on HBASE-8135: --- Increment inherits heapSize() from Mutation. Increment has a field of TimeRange which is not accounted for in Mutation#heapSize() Should we account for this field in Increment#heapSize() ? > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605244#comment-13605244 ] stack commented on HBASE-8135: -- +1 I think I added heapsize method to Mutation when I made Increment a Mutation; didn't add the interface because wasn't sure it was needed generally. > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[ https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605183#comment-13605183 ] nkeywal commented on HBASE-8135: Agreed, I will do that on commit. Are you +1 otherwise? > Mutation should implement HeapSize > -- > > Key: HBASE-8135 > URL: https://issues.apache.org/jira/browse/HBASE-8135 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 0.95.0, 0.96.0, 0.94.5 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.95.0, 0.96.0 > > Attachments: 8135.v1.patch > > > Code is there already. > Doing so would allow to share some code when doing client side buffering. > patch compiles locally, should not impact tests, but not tested locally. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605176#comment-13605176
]
Ted Yu commented on HBASE-8135:
---
{code}
- long heapSize() {
+ public long heapSize() {
{code}
Add @Override.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8135) Mutation should implement HeapSize
[
https://issues.apache.org/jira/browse/HBASE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605056#comment-13605056
]
Hadoop QA commented on HBASE-8135:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574131/8135.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4862//console
This message is automatically generated.
> Mutation should implement HeapSize
> --
>
> Key: HBASE-8135
> URL: https://issues.apache.org/jira/browse/HBASE-8135
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 0.95.0, 0.96.0, 0.94.5
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.95.0, 0.96.0
>
> Attachments: 8135.v1.patch
>
>
> Code is there already.
> Doing so would allow to share some code when doing client side buffering.
> patch compiles locally, should not impact tests, but not tested locally.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
