[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663895#comment-13663895 ] Hudson commented on HBASE-8581: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #538 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/538/]) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484942) Result = FAILURE stack : Files : * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * /hbase/trunk/hbase-client/src/test/resources/log4j.properties * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt, 8581v3.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663824#comment-13663824 ] Hudson commented on HBASE-8581: --- Integrated in hbase-0.95-on-hadoop2 #107 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/107/]) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484941) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484939) Result = FAILURE stack : Files : * /hbase/branches/0.95/hbase-client/src/test/resources/log4j.properties stack : Files : * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java * /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt, 8581v3.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663773#comment-13663773 ] Hudson commented on HBASE-8581: --- Integrated in HBase-TRUNK #4135 (See [https://builds.apache.org/job/HBase-TRUNK/4135/]) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484942) Result = FAILURE stack : Files : * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java * /hbase/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * /hbase/trunk/hbase-client/src/test/resources/log4j.properties * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt, 8581v3.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663705#comment-13663705 ] Hudson commented on HBASE-8581: --- Integrated in hbase-0.95 #208 (See [https://builds.apache.org/job/hbase-0.95/208/]) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484941) HBASE-8581 rpc refactor dropped passing the operation timeout through to the rpcclient (Revision 1484939) Result = SUCCESS stack : Files : * /hbase/branches/0.95/hbase-client/src/test/resources/log4j.properties stack : Files : * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java * /hbase/branches/0.95/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt, 8581v3.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[
https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662568#comment-13662568
]
Hadoop QA commented on HBASE-8581:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583923/8581v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestHCM
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5761//console
This message is automatically generated.
> rpc refactor dropped passing the operation timeout through to the rpcclient
> ---
>
> Key: HBASE-8581
> URL: https://issues.apache.org/jira/browse/HBASE-8581
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.98.0, 0.95.1
>
> Attachments: 8581.txt, 8581v3.txt
>
>
> jd was poking and noticed that we were not passing the operation timeout down
> as rpc timeout as we used to in 0.94. Let me fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662506#comment-13662506 ] Jean-Daniel Cryans commented on HBASE-8581: --- +1 > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt, 8581v3.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[
https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662492#comment-13662492
]
Jean-Daniel Cryans commented on HBASE-8581:
---
That's a sweet test Stack, I would just add a fail() in
RetriesExhaustedException to make it easier to debug. Another nit, {{duration}}
is not super descriptive and it's the duration of a single call and there could
be many of them. Someone could think it's the duration of the whole
{{ServerCallable}}.
> rpc refactor dropped passing the operation timeout through to the rpcclient
> ---
>
> Key: HBASE-8581
> URL: https://issues.apache.org/jira/browse/HBASE-8581
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.98.0, 0.95.1
>
> Attachments: 8581.txt
>
>
> jd was poking and noticed that we were not passing the operation timeout down
> as rpc timeout as we used to in 0.94. Let me fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[
https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662482#comment-13662482
]
Hadoop QA commented on HBASE-8581:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583917/8581.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5759//console
This message is automatically generated.
> rpc refactor dropped passing the operation timeout through to the rpcclient
> ---
>
> Key: HBASE-8581
> URL: https://issues.apache.org/jira/browse/HBASE-8581
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.98.0, 0.95.1
>
> Attachments: 8581.txt
>
>
> jd was poking and noticed that we were not passing the operation timeout down
> as rpc timeout as we used to in 0.94. Let me fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8581) rpc refactor dropped passing the operation timeout through to the rpcclient
[ https://issues.apache.org/jira/browse/HBASE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662480#comment-13662480 ] stack commented on HBASE-8581: -- Looking at 0.94, scanners have different timeout mechanism than this one. > rpc refactor dropped passing the operation timeout through to the rpcclient > --- > > Key: HBASE-8581 > URL: https://issues.apache.org/jira/browse/HBASE-8581 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 0.98.0, 0.95.1 > > Attachments: 8581.txt > > > jd was poking and noticed that we were not passing the operation timeout down > as rpc timeout as we used to in 0.94. Let me fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
