[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710881#comment-13710881 ] Hudson commented on HBASE-8877: --- FAILURE: Integrated in hbase-0.95 #331 (See

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710887#comment-13710887 ] Hudson commented on HBASE-8877: --- FAILURE: Integrated in HBase-TRUNK #4260 (See

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711027#comment-13711027 ] Hudson commented on HBASE-8877: --- FAILURE: Integrated in hbase-0.95-on-hadoop2 #182 (See

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711047#comment-13711047 ] Hudson commented on HBASE-8877: --- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #620

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-17 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711260#comment-13711260 ] Dave Latham commented on HBASE-8877: Thanks everyone for your attention, help, and

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709830#comment-13709830 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-16 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710307#comment-13710307 ] Dave Latham commented on HBASE-8877: Looks good to commit to me. Hadoop QA says that

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-16 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710319#comment-13710319 ] Lars Hofhansl commented on HBASE-8877: -- Will commit in a bit, unless I hear

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-16 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710693#comment-13710693 ] Lars Hofhansl commented on HBASE-8877: -- Actually. Can I get another +1 for

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710704#comment-13710704 ] Ted Yu commented on HBASE-8877: --- +1 Reentrant row locks

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708660#comment-13708660 ] Dave Latham commented on HBASE-8877: 3 +1's on the dev mailing list for the removal of

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708754#comment-13708754 ] stack commented on HBASE-8877: -- +1 on patch. Will commit to trunk in few hours unless

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708794#comment-13708794 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708803#comment-13708803 ] Lars Hofhansl commented on HBASE-8877: -- Do we need to do reference counting on the

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708851#comment-13708851 ] Dave Latham commented on HBASE-8877: [~lhofhansl] Agreed that it's a bit fragile and

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708869#comment-13708869 ] stack commented on HBASE-8877: -- bq. ...what if in the future a method does its own locking...

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709140#comment-13709140 ] Ted Yu commented on HBASE-8877: --- {code} +if (existingContext != this) { +

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709217#comment-13709217 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709354#comment-13709354 ] Lars Hofhansl commented on HBASE-8877: -- Awesome. Thanks for bearing with our (or at

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709387#comment-13709387 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709416#comment-13709416 ] Dave Latham commented on HBASE-8877: And here's the diff up on review board if that

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709425#comment-13709425 ] Lars Hofhansl commented on HBASE-8877: -- Patch looks good. In the context of

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709428#comment-13709428 ] Dave Latham commented on HBASE-8877: Now that it's done, I'd prefer refCounts. I

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709441#comment-13709441 ] Lars Hofhansl commented on HBASE-8877: -- Let's do that. +1 from me.

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709475#comment-13709475 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-14 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708016#comment-13708016 ] Lars Hofhansl commented on HBASE-8877: -- 0.94 patch looks good. I played through

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708035#comment-13708035 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708163#comment-13708163 ] stack commented on HBASE-8877: -- Very nice patch. Nice cleanup. A bit of doc on this would

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707747#comment-13707747 ] Dave Latham commented on HBASE-8877: Reattached HBASE-8877-v4.patch for Hadoop QA to

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707750#comment-13707750 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707776#comment-13707776 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707787#comment-13707787 ] Dave Latham commented on HBASE-8877: Note the above comment is referencing the HRegion

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707808#comment-13707808 ] Hadoop QA commented on HBASE-8877: -- {color:green}+1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707809#comment-13707809 ] Ted Yu commented on HBASE-8877: --- +1 on patch v6. Reentrant row locks

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707421#comment-13707421 ] Ted Yu commented on HBASE-8877: --- Nice results. What was the unit for min/max/mean values ?

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707431#comment-13707431 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-12 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707481#comment-13707481 ] Dave Latham commented on HBASE-8877: {quote}What was the unit for min/max/mean values

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707555#comment-13707555 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702034#comment-13702034 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702037#comment-13702037 ] Ted Yu commented on HBASE-8877: --- +1 on patch v3. Reentrant row locks

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-07 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701712#comment-13701712 ] Ted Yu commented on HBASE-8877: --- {code} - public Integer getLock(Integer lockid, byte []

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-07 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701745#comment-13701745 ] Dave Latham commented on HBASE-8877: {quote}Looks like the following methods should be

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701747#comment-13701747 ] Anoop Sam John commented on HBASE-8877: --- Should we allow acquire and release locks

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-07 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701796#comment-13701796 ] ramkrishna.s.vasudevan commented on HBASE-8877: --- bq.Should we allow acquire

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-06 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701422#comment-13701422 ] Dave Latham commented on HBASE-8877: {quote}+1 on the CP interface change. There might

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701447#comment-13701447 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-05 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700940#comment-13700940 ] Dave Latham commented on HBASE-8877: A few changes in this patch compared to the

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700971#comment-13700971 ] Ted Yu commented on HBASE-8877: --- {code} - public OperationStatus[] batchMutate( -

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700996#comment-13700996 ] Hadoop QA commented on HBASE-8877: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-8877) Reentrant row locks

2013-07-05 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701013#comment-13701013 ] Andrew Purtell commented on HBASE-8877: --- +1 on the CP interface change. There might