David Manning created HBASE-26718:
-------------------------------------

             Summary: HFileArchiver can remove referenced StoreFiles from the 
archive
                 Key: HBASE-26718
                 URL: https://issues.apache.org/jira/browse/HBASE-26718
             Project: HBase
          Issue Type: Bug
          Components: Compaction, HFile, snapshots
    Affects Versions: 2.0.0, 3.0.0-alpha-1, 1.0.0
            Reporter: David Manning
            Assignee: David Manning


There is a comment in {{HFileArchiver#resolveAndArchiveFile}}:
{code:java}
// if the file already exists in the archive, move that one to a timestamped 
backup. This is a
// really, really unlikely situtation, where we get the same name for the 
existing file, but
// is included just for that 1 in trillion chance.
{code}

In reality, we did encounter this frequently enough to cause problems. More 
details will be included and linked in a separate issue.

But regardless of how we get into this situation, we can consider a different 
approach to solving it. If we assume store files are immutable, and a store 
file with the same name and location already exists in the archive, then it can 
be safer to assume the file was already archived successfully, and react 
accordingly.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to