Jieshan Bean created HBASE-7750:
-----------------------------------

             Summary: We should throw IOE when calling 
HRegionServer#replicateLogEntries if ReplicationSink is null
                 Key: HBASE-7750
                 URL: https://issues.apache.org/jira/browse/HBASE-7750
             Project: HBase
          Issue Type: Bug
          Components: Replication
    Affects Versions: 0.94.4, 0.96.0
            Reporter: Jieshan Bean


It may be an expected behavior, but I think it's better to do something. 
We configured "hbase.replication" as true in master cluster, and added peer. 
But forgot to configure "hbase.replication" on slave cluster side.
ReplicationSource read HLog, shipped log edits, and logged position. Everything 
seemed alright. But data was not present in slave cluster.

So I think, slave cluster should throw exception to master cluster instead of 
return directly:

{code}
  public void replicateLogEntries(final HLog.Entry[] entries)
  throws IOException {
    checkOpen();
    if (this.replicationSinkHandler == null) return;
    this.replicationSinkHandler.replicateLogEntries(entries);
  }
{code}

I would like to hear your comments on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to