[
https://issues.apache.org/jira/browse/HBASE-24695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John resolved HBASE-24695.
------------------------------------
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2 and trunk. Thanks for the reviews Duo and Ram.
> FSHLog - close the current WAL file in a background thread
> ----------------------------------------------------------
>
> Key: HBASE-24695
> URL: https://issues.apache.org/jira/browse/HBASE-24695
> Project: HBase
> Issue Type: Improvement
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> We have this as a TODO in code already
> {code}
> // It is at the safe point. Swap out writer from under the blocked writer
> thread.
> // TODO: This is close is inline with critical section. Should happen
> in background?
> if (this.writer != null) {
> oldFileLen = this.writer.getLength();
> try {
> TraceUtil.addTimelineAnnotation("closing writer");
> this.writer.close();
> TraceUtil.addTimelineAnnotation("writer closed");
> this.closeErrorCount.set(0);
> }
> {code}
> This close call in critical section and writes are blocked. Lets move this
> close call into another WALCloser thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
