[jira] [Updated] (HBASE-14575) Relax region read lock for compactions
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry He updated HBASE-14575: - Description: Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock. Here is summary from parent issue: Another idea is we can reduce the scope of when the read lock is held during compaction. In theory the compactor only needs a region read lock while deciding what files to compact and at the time of committing the compaction. We're protected from the case of region close events because compactions are checking (every 10k bytes written) if the store has been closed in order to abort in such a case. was: Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock. Here is summary from parent issue: Another idea is we can reduce the scope of when the read lock is held during compaction. In theory the compactor only needs a region read lock while deciding what files to compact and at the time of committing the compaction. We're protected from the case of region close events because compactions are checking (every 10k bytes written) if the store has been closed in order to abort in such a case. Note: Fixed in subtask HBASE-14575 > Relax region read lock for compactions > -- > > Key: HBASE-14575 > URL: https://issues.apache.org/jira/browse/HBASE-14575 > Project: HBase > Issue Type: Sub-task > Components: Compaction, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk > Fix For: 2.0.0, 1.3.0 > > Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch, > 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt, > 14575-v6.txt, 14575-v7.txt, 14575.v00.patch > > > Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope > of critical section under which compactions hold the region read lock. > Here is summary from parent issue: > Another idea is we can reduce the scope of when the read lock is held during > compaction. In theory the compactor only needs a region read lock while > deciding what files to compact and at the time of committing the compaction. > We're protected from the case of region close events because compactions are > checking (every 10k bytes written) if the store has been closed in order to > abort in such a case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14575) Relax region read lock for compactions
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry He updated HBASE-14575: - Description: Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock. Here is summary from parent issue: Another idea is we can reduce the scope of when the read lock is held during compaction. In theory the compactor only needs a region read lock while deciding what files to compact and at the time of committing the compaction. We're protected from the case of region close events because compactions are checking (every 10k bytes written) if the store has been closed in order to abort in such a case. Note: Fixed in subtask HBASE-14575 was: Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock. Here is summary from parent issue: Another idea is we can reduce the scope of when the read lock is held during compaction. In theory the compactor only needs a region read lock while deciding what files to compact and at the time of committing the compaction. We're protected from the case of region close events because compactions are checking (every 10k bytes written) if the store has been closed in order to abort in such a case. > Relax region read lock for compactions > -- > > Key: HBASE-14575 > URL: https://issues.apache.org/jira/browse/HBASE-14575 > Project: HBase > Issue Type: Sub-task > Components: Compaction, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk > Fix For: 2.0.0, 1.3.0 > > Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch, > 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt, > 14575-v6.txt, 14575-v7.txt, 14575.v00.patch > > > Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope > of critical section under which compactions hold the region read lock. > Here is summary from parent issue: > Another idea is we can reduce the scope of when the read lock is held during > compaction. In theory the compactor only needs a region read lock while > deciding what files to compact and at the time of committing the compaction. > We're protected from the case of region close events because compactions are > checking (every 10k bytes written) if the store has been closed in order to > abort in such a case. > Note: Fixed in subtask HBASE-14575 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14575) Relax region read lock for compactions
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14575: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Unit test suite results are quite clean. Thanks for the reviews. > Relax region read lock for compactions > -- > > Key: HBASE-14575 > URL: https://issues.apache.org/jira/browse/HBASE-14575 > Project: HBase > Issue Type: Sub-task > Components: Compaction, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk > Fix For: 2.0.0, 1.3.0 > > Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch, > 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt, > 14575-v6.txt, 14575-v7.txt, 14575.v00.patch > > > Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope > of critical section under which compactions hold the region read lock. > Here is summary from parent issue: > Another idea is we can reduce the scope of when the read lock is held during > compaction. In theory the compactor only needs a region read lock while > deciding what files to compact and at the time of committing the compaction. > We're protected from the case of region close events because compactions are > checking (every 10k bytes written) if the store has been closed in order to > abort in such a case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14575) Relax region read lock for compactions
[ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-14575: --- Summary: Relax region read lock for compactions (was: Reduce scope of compactions holding region lock) > Relax region read lock for compactions > -- > > Key: HBASE-14575 > URL: https://issues.apache.org/jira/browse/HBASE-14575 > Project: HBase > Issue Type: Sub-task > Components: Compaction, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk > Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch, > 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt, > 14575-v6.txt, 14575-v7.txt, 14575.v00.patch > > > Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope > of critical section under which compactions hold the region read lock. > Here is summary from parent issue: > Another idea is we can reduce the scope of when the read lock is held during > compaction. In theory the compactor only needs a region read lock while > deciding what files to compact and at the time of committing the compaction. > We're protected from the case of region close events because compactions are > checking (every 10k bytes written) if the store has been closed in order to > abort in such a case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
