[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Resolution: Fixed Status: Resolved (was: Patch Available) Let me be optimistic and resolve this. Will reopen if new issues. I've been watching this and seems to be just doing the right thing. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch, > HBASE-17056.master.006.patch, HBASE-17056.master.007.patch, > HBASE-17056.master.007.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.007.patch Just retrying. It is taking for ever but everything has been touched so everything is running; all modules and then we run the root one which reruns all unit tests again. Will keep an eye on it. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch, > HBASE-17056.master.006.patch, HBASE-17056.master.007.patch, > HBASE-17056.master.007.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Status: Patch Available (was: Reopened) > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch, > HBASE-17056.master.006.patch, HBASE-17056.master.007.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.007.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch, > HBASE-17056.master.006.patch, HBASE-17056.master.007.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.006.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch, > HBASE-17056.master.006.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.006.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch, HBASE-17056.master.006.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.005.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch, > HBASE-17056.master.005.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.004.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch, HBASE-17056.master.004.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Priority: Critical (was: Major) > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master and to branch-2. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Release Note: Purge all checked in generated protobuf files (30MB). Generate protobuf files inline with the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead. Side-effect: Our protobuf went from 3.1.0 to 3.3.1. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files. was: Purge all checked in generated protobuf files. Generate protobuf files inline with the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead. Side-effect: Our protobuf went from 3.1.0 to 3.3.1. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.003.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch, > HBASE-17056.master.003.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.002.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch, HBASE-17056.master.002.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Release Note: Purge all checked in generated protobuf files. Generate protobuf files inline with the build. Remove checked-in and patched protobuf. Get it from new hbase-thirdparty instead. Side-effect: Our protobuf went from 3.1.0 to 3.3.1. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files. was: Generate protobuf files inline with the build. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Release Note: Generate protobuf files inline with the build. Build does not take noticeably longer (still about 2.5 minutes to do a mvn clean install -DskipTests). IDEs will probably require a mvn build first else they'll complain about missing (generated) files. was: Generate protobuf files inline with the build. IDEs will probably require a mvn build first else they'll complain about missing (generated) files. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Status: Patch Available (was: In Progress) > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Status: In Progress (was: Patch Available) > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Release Note: Generate protobuf files inline with the build. IDEs will probably require a mvn build first else they'll complain about missing (generated) files. Affects Version/s: 2.0.0 Status: Patch Available (was: Open) > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: HBASE-17056.master.001.patch > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: stack > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch, > HBASE-17056.master.001.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17056) Remove checked in PB generated files
[ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-17056: -- Attachment: 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch Example. Does a few modules. Has protos generated on the fly. Removed from hbase-endpoint, hbase-rsgroup, and hbase-spark. > Remove checked in PB generated files > - > > Key: HBASE-17056 > URL: https://issues.apache.org/jira/browse/HBASE-17056 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar > Fix For: 2.0.0 > > Attachments: > 0002-HBASE-17056-Remove-checked-in-PB-generated-files.patch > > > Now that we have the new PB maven plugin, there is no need to have the PB > files checked in to the repo. The reason we did that was to ease up developer > env setup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
