[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-17611: --- Fix Version/s: 1.4.0 > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 2.0.0, 1.4.0, 1.3.1 > > Attachments: HBASE-17611.001.patch, HBASE-17611.002.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-17611: --- Fix Version/s: (was: 1.4.0) > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 2.0.0, 1.3.1 > > Attachments: HBASE-17611.001.patch, HBASE-17611.002.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Helmling updated HBASE-17611: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.4.0 2.0.0 Status: Resolved (was: Patch Available) Committed to branch-1.3+. Thanks for the review, [~tedyu]. > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 2.0.0, 1.4.0, 1.3.1 > > Attachments: HBASE-17611.001.patch, HBASE-17611.002.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Helmling updated HBASE-17611: -- Attachment: HBASE-17611.002.patch Thanks for taking a look [~tedyu]. The "testMetricsPrecision" table will get cleaned up with the rest of the test data anyway, but here's a new patch which deletes the table at the end of the test. TestThriftServerCmdLine passes for me locally. Let's see if it reappears in this run. > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 1.3.1 > > Attachments: HBASE-17611.001.patch, HBASE-17611.002.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Helmling updated HBASE-17611: -- Attachment: HBASE-17611.001.patch Attaching a simple fix and test for coverage. > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 1.3.1 > > Attachments: HBASE-17611.001.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HBASE-17611) Thrift 2 per-call latency metrics are capped at ~ 2 seconds
[ https://issues.apache.org/jira/browse/HBASE-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Helmling updated HBASE-17611: -- Status: Patch Available (was: Open) > Thrift 2 per-call latency metrics are capped at ~ 2 seconds > --- > > Key: HBASE-17611 > URL: https://issues.apache.org/jira/browse/HBASE-17611 > Project: HBase > Issue Type: Bug > Components: metrics, Thrift >Reporter: Gary Helmling >Assignee: Gary Helmling > Fix For: 1.3.1 > > Attachments: HBASE-17611.001.patch > > > Thrift 2 latency metrics are measured in nanoseconds. However, the duration > used for per-method latencies is cast to an int, meaning the values are > capped at 2.147 seconds. Let's use a long instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
