[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18525: -- Fix Version/s: 2.0.0 > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Umesh Agashe >Priority: Major > Fix For: 2.0.0-alpha-2, 2.0.0 > > Attachments: 18525.v1.txt, 18525.v2.txt, hbase-18525.master.003.patch > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18525: -- Resolution: Fixed Assignee: Umesh Agashe (was: Ted Yu) Hadoop Flags: Reviewed Fix Version/s: 2.0.0-alpha-2 Status: Resolved (was: Patch Available) Pushed to master and branch-2. Fix the javadoc warning before I did so (did a minor edit on the nice writeup before commit... its really good). Lets open new issue if we see more failures like this. Chatting w/ [~uagashe], we predict that we'll see more interesting failure scenarios after the change to make unassignprocedure fail when it can't communicate w/ the remote server so we should be on the watch for more like this issue filed by Ted. > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Umesh Agashe > Fix For: 2.0.0-alpha-2 > > Attachments: 18525.v1.txt, 18525.v2.txt, hbase-18525.master.003.patch > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18525: - Status: Patch Available (was: Open) > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt, 18525.v2.txt, hbase-18525.master.003.patch > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18525: - Attachment: hbase-18525.master.003.patch Hi [~stack], [~tedyu]: [~stack] and I discussed it further and I also looked at your patch. As [~stack] have commented, currently AssignProcedure and UnassignProcedure are not symmetric and there are some intricacies involved. We agree that simplicity is desired when possible. I have tried to capture our thoughts on this in Javadoc and I have also updated the doc here: https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.6lielw794sfo. [~tedyu], let me know your thoughts. [~stack], please review the patch and let me know if Javadoc looks okay for RegionTransitionProcedure class? > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt, 18525.v2.txt, hbase-18525.master.003.patch > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18525: --- Status: Open (was: Patch Available) > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt, 18525.v2.txt > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18525: --- Attachment: 18525.v2.txt > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt, 18525.v2.txt > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18525: --- Status: Patch Available (was: Open) > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18525) TestAssignmentManager#testSocketTimeout fails in master branch
[ https://issues.apache.org/jira/browse/HBASE-18525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18525: --- Attachment: 18525.v1.txt [~uagashe]: Can you take a look at the patch ? > TestAssignmentManager#testSocketTimeout fails in master branch > -- > > Key: HBASE-18525 > URL: https://issues.apache.org/jira/browse/HBASE-18525 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18525.v1.txt > > > Toward the end of the test output, I saw: > {code} > 2017-08-05 03:30:16,591 INFO [Time-limited test] > assignment.TestAssignmentManager(446): ExecutionException > java.util.concurrent.ExecutionException: > org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:104) > at > org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait$ProcedureFuture.get(ProcedureSyncWait.java:62) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.waitOnFuture(TestAssignmentManager.java:444) > at > org.apache.hadoop.hbase.master.assignment.TestAssignmentManager.testSocketTimeout(TestAssignmentManager.java:255) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.lang.Thread.run(Thread.java:745) > Caused by: org.apache.hadoop.hbase.master.procedure.ServerCrashException: > ServerCrashProcedure pid=3, server=localhost,103,1 > at > org.apache.hadoop.hbase.master.assignment.UnassignProcedure.updateTransition(UnassignProcedure.java:169) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:274) > at > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:57) > at > org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:847) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1440) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1209) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:79) > at > org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1719) > {code} > This test failure seems to happen after HBASE-18491 was checked in. > Looking at the change in UnassignProcedure, it seems we should handle the two > conditions differently: > {code} > if (serverCrashed.get() || !isServerOnline(env, regionNode)) { > {code} > With attached patch, TestAssignmentManager#testSocketTimeout and > TestServerCrashProcedure#testRecoveryAndDoubleExecutionOnRsWithMeta pass. -- This message was sent by Atlassian JIRA (v6.4.14#64029)