[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair updated HBASE-18807: -- Labels: quota (was: ) > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Labels: quota > Fix For: 2.0.0-alpha-4, 2.0.0 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the review, Ted. Anoop, let me know if you see anything else to fix -- I can amend the commit if necessary. > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Fix Version/s: 3.0.0 > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 3.0.0, 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Attachment: HBASE-18807.004.branch-2.patch .004 should fix the (valid) findbugs warnings. Missed these in the cleanup from .003 > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch, > HBASE-18807.004.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[
https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-18807:
---
Attachment: HBASE-18807.003.branch-2.patch
.003 Lots of cleanup. Some missing test annotations. Marked
{{GlobalQuotaSettings}} as {{LimitedPrivate(COPROC)}}. Better javadoc.
> Remove PB references from Observers for Quotas
> --
>
> Key: HBASE-18807
> URL: https://issues.apache.org/jira/browse/HBASE-18807
> Project: HBase
> Issue Type: Sub-task
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18807.001.branch-2.patch,
> HBASE-18807.002.branch-2.patch, HBASE-18807.003.branch-2.patch
>
>
> Break-out from the parent:
> Same idea, just applied to the Observer methods for pre/post quota
> operations. Requires changes to MasterQuotaManager and the QuotaSettings
> implementations as some business logic is written on the PB objects directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Attachment: HBASE-18807.002.branch-2.patch .002 I believe I've gotten all of the tests passing again. Still need to address the stability concerns Anoop mentioned, as well as do some general cleanup (logging, comments) > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch, > HBASE-18807.002.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Attachment: HBASE-18807.001.branch-2.patch .001 Preliminary patch (wouldn't suggest reviewing unless interested in double-checking approach). Wanted to get an earlier QA run. Most of the quota-related tests are passing now, but there are some laggards. Need to clean up the code as a whole as well. The general approach is the same, but this turned out to be a rather large undertaking to untangle. > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Status: Patch Available (was: Open) > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18807.001.branch-2.patch > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18807) Remove PB references from Observers for Quotas
[ https://issues.apache.org/jira/browse/HBASE-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-18807: --- Fix Version/s: (was: 2.0.0-alpha-3) 2.0.0-alpha-4 > Remove PB references from Observers for Quotas > -- > > Key: HBASE-18807 > URL: https://issues.apache.org/jira/browse/HBASE-18807 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 2.0.0-alpha-4 > > > Break-out from the parent: > Same idea, just applied to the Observer methods for pre/post quota > operations. Requires changes to MasterQuotaManager and the QuotaSettings > implementations as some business logic is written on the PB objects directly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
