[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-11-16 Thread Jonathan Hsieh (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh updated HBASE-4225:
--

Fix Version/s: 0.92.0

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.92.0, 0.90.5

 Attachments: 4225.trunk, HBASE-4225_0.90.patch, 
 HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4225:
--

Status: Patch Available  (was: Open)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Attachment: HBASE-4225_0.90_2.patch

As discussed add the new Class OperationStatus

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, 
 HBASE-4225_0.90_2.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Status: Open  (was: Patch Available)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, 
 HBASE-4225_0.90_2.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Attachment: HBASE-4225_0.90_3.patch

Thanks for the comments.
Removed the ^M and added javadoc.

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, 
 HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Status: Open  (was: Patch Available)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, 
 HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Status: Patch Available  (was: Open)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, 
 HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4225:
--

Attachment: 4225.trunk

Patch for TRUNK.
TestHRegion passed.

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: 4225.trunk, HBASE-4225_0.90.patch, 
 HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-23 Thread Ted Yu (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-4225:
--

  Resolution: Fixed
Release Note: Created a new class OperationStatus that wraps 
OperationStatusCode and an exception message, most of the patch consists of the 
former replacing the latter.
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: 4225.trunk, HBASE-4225_0.90.patch, 
 HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-22 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Attachment: HBASE-4225_0.90.patch

Submitting the patch for 0.90.x version as given in the defect description.

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-22 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Status: Patch Available  (was: Open)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-22 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Attachment: HBASE-4225_0.90_1.patch

@Ted,
Changed the javadoc as per the comment.:)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi doesn't say which family is bad

2011-08-22 Thread ramkrishna.s.vasudevan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ramkrishna.s.vasudevan updated HBASE-4225:
--

Status: Open  (was: Patch Available)

 NoSuchColumnFamilyException in multi doesn't say which family is bad
 

 Key: HBASE-4225
 URL: https://issues.apache.org/jira/browse/HBASE-4225
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: ramkrishna.s.vasudevan
Priority: Critical
 Fix For: 0.90.5

 Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch


 It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
 {code}
 LOG.warn(No such column family in batch put, nscf);
 batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
 {code}
 So we lose the family here, all we know is there's a bad one, that's what's 
 in HRS.multi:
 {code}
 } else if (code == OperationStatusCode.BAD_FAMILY) {
   result = new NoSuchColumnFamilyException();
 {code}
 We can't just throw the exception like that, we need to say which one is bad 
 even if it requires testing all passed MultiActions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira